search

Mu2e / Offline

Offline software for the Mu2e experiment
Apache License 2.0
8 stars 81 forks source link

small fixes to compile with cmake #1265

Closed gianipez closed 4 months ago

FNALbuild commented 4 months ago

Hi @gianipez, You have proposed changes to files in these packages:

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

:hourglass: The following tests have been triggered for 995e2d947dece9068a276cc719920edfae55e803: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild commented 4 months ago

:sunny: The build tests passed at 995e2d947dece9068a276cc719920edfae55e803.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged 995e2d947dece9068a276cc719920edfae55e803 at 79ed54abf0d63b65d0949b3bdc425c410176c490
build (prof) :white_check_mark: Log file. Build time: 11 min 14 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :white_check_mark: TODO (0) FIXME (0) in 1 files
clang-tidy :large_orange_diamond: 0 errors 438 warnings
whitespace check :white_check_mark: no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 995e2d947dece9068a276cc719920edfae55e803 after being merged into the base branch at 79ed54abf0d63b65d0949b3bdc425c410176c490.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

kutschke commented 4 months ago

@gianipez I see that you have been adding commits. Please let me know when you are finished and I will merge it.

kutschke commented 4 months ago

@eflumerf Do you need a new tag after this merge? If so, what should it be, d11_02_01?

eflumerf commented 4 months ago

I've asked Giani if he'll want a new tag; if he does he will have to update the CMakeLists.txt version so that the UPS product is generated with the right version number

gianipez commented 4 months ago

Thanks for asking, Eric. I don't think we need a new tag. I'm done with the commits, @kutschke , so feel free to merge at your convenience.

kutschke commented 4 months ago

There is no coverage in the CI so I am not rerunning the CI. Merging now.