Mu2e / Offline

Offline software for the Mu2e experiment
Apache License 2.0
8 stars 79 forks source link

Add flags for APR and MPR and set them appropriately #1268

Closed brownd1978 closed 1 month ago

FNALbuild commented 1 month ago

Hi @brownd1978, You have proposed changes to files in these packages:

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

:hourglass: The following tests have been triggered for 0b8bdcd75250b4920d5c5479180c8b155ba4fcd8: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild commented 1 month ago

:sunny: The build tests passed at 0b8bdcd75250b4920d5c5479180c8b155ba4fcd8.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged 0b8bdcd75250b4920d5c5479180c8b155ba4fcd8 at 4b7e9fcbc96e21d1335c46bc0c951bef11a19ad4
build (prof) :white_check_mark: Log file. Build time: 11 min 05 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :white_check_mark: TODO (0) FIXME (0) in 5 files
clang-tidy :large_orange_diamond: 0 errors 626 warnings
whitespace check :white_check_mark: no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 0b8bdcd75250b4920d5c5479180c8b155ba4fcd8 after being merged into the base branch at 4b7e9fcbc96e21d1335c46bc0c951bef11a19ad4.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

kutschke commented 1 month ago

@matthewstortini Thanks for getting to this quickly. The PR also looks good to me.