Mu2e / Offline

Offline software for the Mu2e experiment
Apache License 2.0
8 stars 81 forks source link

update for TrackerMC cmake build #1274

Closed rlcee closed 4 months ago

FNALbuild commented 4 months ago

Hi @rlcee, You have proposed changes to files in these packages:

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

:hourglass: The following tests have been triggered for ad957c1f8db8a04dd91cc864aca501e71a6b9907: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

kutschke commented 4 months ago

The file add/modify/delete list for PR #1245 is:

A CommonMC/src/ProtonBunchTimeMCFromProtonBunchTime_module.cc (52) M EventMixing/inc/Mu2eProductMixer.hh (25) A EventMixing/src/MixDigis_module.cc (113) M EventMixing/src/Mu2eProductMixer.cc (58) M MCDataProducts/inc/StrawDigiMC.hh (8) M MCDataProducts/src/StrawDigiMC.cc (8) A TrackerMC/inc/StrawDigiBundle.hh (35) A TrackerMC/inc/StrawDigiBundleCollection.hh (92) A TrackerMC/inc/TimeBasedBucket.hh (93) A TrackerMC/src/StrawDigiBundle.cc (61) A TrackerMC/src/StrawDigiBundleCollection.cc (158) M TrackerMC/src/StrawDigisFromStrawGasSteps_module.cc (63)

Do you also so need to add a cmake rule for: CommonMC/src/ProtonBunchTimeMCFromProtonBunchTime_module.cc EventMixing/src/MixDigis_module.cc

FNALbuild commented 4 months ago

:sunny: The build tests passed at ad957c1f8db8a04dd91cc864aca501e71a6b9907.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged ad957c1f8db8a04dd91cc864aca501e71a6b9907 at 9beacd23884b35d4586b48736f29afd8691590c0
build (prof) :white_check_mark: Log file. Build time: 10 min 58 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :white_check_mark: TODO (0) FIXME (0) in 0 files
clang-tidy :white_check_mark: 0 errors 0 warnings
whitespace check :white_check_mark: no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at ad957c1f8db8a04dd91cc864aca501e71a6b9907 after being merged into the base branch at 9beacd23884b35d4586b48736f29afd8691590c0.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

rlcee commented 4 months ago

Thanks Rob, I added the modules.

kutschke commented 4 months ago

No need to rerun CI, which has no coverage for this change.