Mu2e / Offline

Offline software for the Mu2e experiment
Apache License 2.0
8 stars 81 forks source link

Updated Wideband simulation scripts #1281

Closed ehrlich-uva closed 3 months ago

ehrlich-uva commented 4 months ago

This PR has no impact on other simulations outside of the Wideband CRV simulations

FNALbuild commented 4 months ago

Hi @ehrlich-uva, You have proposed changes to files in these packages:

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

The following users requested to be notified about changes to these packages: @resnegfk

:hourglass: The following tests have been triggered for b20c24619121c984275da31ff9d2d7fa49c485c4: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

ehrlich-uva commented 4 months ago

@kutschke Could you please add @oksuzian as a reviewer?

FNALbuild commented 4 months ago

:sunny: The build tests passed at b20c24619121c984275da31ff9d2d7fa49c485c4.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged b20c24619121c984275da31ff9d2d7fa49c485c4 at fc6b3b1e954528ac4f5f8b3f0ad965633dc79e64
build (prof) :white_check_mark: Log file. Build time: 10 min 53 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :white_check_mark: TODO (0) FIXME (0) in 1 files
clang-tidy :large_orange_diamond: 0 errors 225 warnings
whitespace check :white_check_mark: no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at b20c24619121c984275da31ff9d2d7fa49c485c4 after being merged into the base branch at fc6b3b1e954528ac4f5f8b3f0ad965633dc79e64.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

kutschke commented 4 months ago

@ehrlich-uva a gentle reminder that there are several requests in the review so far.

ehrlich-uva commented 4 months ago

@kutschke I'm working on it.

kutschke commented 3 months ago

@kutschke I'm working on it.

Let me know when you are done and I will rerun the CI.

ehrlich-uva commented 3 months ago

I pushed the requested changes.

kutschke commented 3 months ago

@FNALbuild run build test

FNALbuild commented 3 months ago

:hourglass: The following tests have been triggered for 634db4aa24bed374b93246b3888afe41626e672f: build (Build queue has 1 jobs)

FNALbuild commented 3 months ago

:memo: The HEAD of main has changed to 13c2b501d4b4088931f80f4696b1535868bd72d2. Tests are now out of date.

FNALbuild commented 3 months ago

:sunny: The build tests passed at 634db4aa24bed374b93246b3888afe41626e672f.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged 634db4aa24bed374b93246b3888afe41626e672f at fc6b3b1e954528ac4f5f8b3f0ad965633dc79e64
build (prof) :white_check_mark: Log file. Build time: 21 min 09 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :white_check_mark: TODO (0) FIXME (0) in 1 files
clang-tidy :large_orange_diamond: 0 errors 225 warnings
whitespace check :white_check_mark: no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 634db4aa24bed374b93246b3888afe41626e672f after being merged into the base branch at fc6b3b1e954528ac4f5f8b3f0ad965633dc79e64.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.