search

Mu2e / Offline

Offline software for the Mu2e experiment
Apache License 2.0
8 stars 81 forks source link

Add Nhits to SimpleKalSeedSelector #1287

Closed brownd1978 closed 3 months ago

FNALbuild commented 3 months ago

Hi @brownd1978, You have proposed changes to files in these packages:

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

:hourglass: The following tests have been triggered for 0433a1eddf72cc2257a1bd974c7988865aa8691e: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild commented 3 months ago

:sunny: The build tests passed at 0433a1eddf72cc2257a1bd974c7988865aa8691e.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged 0433a1eddf72cc2257a1bd974c7988865aa8691e at 14380643fcfde733a6762c0c7e0e12db97458e1f
build (prof) :white_check_mark: Log file. Build time: 04 min 09 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :white_check_mark: TODO (0) FIXME (0) in 2 files
clang-tidy :large_orange_diamond: 0 errors 104 warnings
whitespace check :white_check_mark: no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 0433a1eddf72cc2257a1bd974c7988865aa8691e after being merged into the base branch at 14380643fcfde733a6762c0c7e0e12db97458e1f.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

brownd1978 commented 3 months ago

In Trkana, yes. There is a PR in for that.

On Mon, Jun 17, 2024 at 1:23 PM Rob Kutschke @.***> wrote:

@.**** commented on this pull request.

In TrkReco/inc/SimpleKalSeedSelector.hh https://github.com/Mu2e/Offline/pull/1287#discussion_r1643391660:

@@ -13,16 +13,18 @@ namespace mu2e { struct Config { using Name=fhicl::Name; using Comment=fhicl::Comment;

  • fhicl::Atom minmom{Name("MinimumMomentum"), Comment("Minimum fit momentum ")};
  • fhicl::Atom maxmom{Name("MaximumMomentum"), Comment("Maximum fit momentum ")};
  • fhicl::Atom minfcon{Name("MinimumFitConsistency"), Comment("Minimum fit consistency ")};
  • fhicl::Atom minmom{Name("MinMomentum"), Comment("Minimum fit momentum ")};
  • fhicl::Atom maxmom{Name("MaxMomentum"), Comment("Maximum fit momentum ")};
  • fhicl::Atom minfcon{Name("MinFitConsistency"), Comment("Minimum fit consistency ")};
  • fhicl::Atom minnactive{Name("MinActiveHits"), Comment("Minimum # of active hits ")};

Are there any prologs that need updating for the name changes?

— Reply to this email directly, view it on GitHub https://github.com/Mu2e/Offline/pull/1287#pullrequestreview-2123839011, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAH577LNC5K3IJKC6HGSCDZH5AVLAVCNFSM6AAAAABJOUPOU6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDCMRTHAZTSMBRGE . You are receiving this because you were mentioned.Message ID: @.***>

-- David Brown @.*** Office Phone (510) 486-7261 Lawrence Berkeley National Lab M/S 50R5008 (50-6026C) Berkeley, CA 94720