search

Mu2e / Offline

Offline software for the Mu2e experiment
Apache License 2.0
8 stars 79 forks source link

fix inverted flag to propagate preloaded StrawDigiMCs #1293

Closed edcallaghan closed 2 weeks ago

edcallaghan commented 2 weeks ago

This PR fixes a bug present in https://github.com/Mu2e/Offline/pull/1245, which introduced the overlay of simulated tracker digis onto a collection of preexisting digis, which may or may not have been produced by earlier simulation. Whether or not the preexisting digis were produced by simulation is maintained by a field in StrawDigiMC, which is set in the StrawDigisFromStrawGasSteps module, following fcl configuration. The original implementation used the flag in an inverted fashion, marking presimulated digis as non-simulated, and vice versa. This does not effect any tagged datasets.

FNALbuild commented 2 weeks ago

Hi @edcallaghan, You have proposed changes to files in these packages:

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

:hourglass: The following tests have been triggered for 629ddbbe2afdeec20651a8e3f36af605e961ae74: build (Build queue has 7 jobs)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild commented 2 weeks ago

:sunny: The build tests passed at 629ddbbe2afdeec20651a8e3f36af605e961ae74.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged 629ddbbe2afdeec20651a8e3f36af605e961ae74 at 684bac4f22a1fa29f6bfd661300432e492dccbdd
build (prof) :white_check_mark: Log file. Build time: 04 min 10 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :large_orange_diamond: TODO (0) FIXME (7) in 1 files
clang-tidy :large_orange_diamond: 0 errors 407 warnings
whitespace check :white_check_mark: no whitespace errors found

N.B. These results were obtained from a build of this Pull Request at 629ddbbe2afdeec20651a8e3f36af605e961ae74 after being merged into the base branch at 684bac4f22a1fa29f6bfd661300432e492dccbdd.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

edcallaghan commented 2 weeks ago

Thanks!