search

Mu2e / Offline

Offline software for the Mu2e experiment
Apache License 2.0
8 stars 82 forks source link

Remove documenting histograms from Generators to an accompanying analyzer module #1352

Open kutschke opened 2 weeks ago

kutschke commented 2 weeks ago

I the early days of Mu2e we wrote event generator modules to include histotgrams that document the generator's actions. We now prefer separate modules - a clean generator module and an accompanying analyzer module. The reason is that this makes it possible to run just the analyzer module and point it at an existing data product.

There are some event generators that still are organized the old way. One example is:

https://github.com/Mu2e/Offline/blob/main/EventGenerator/src/RPCGun_module.cc

As I discover more I will edit this comment to add them (and to mark then as resolved when they are resolved ).

sophiemiddleton commented 2 weeks ago

Hi Rob, I believe we have generic plotting module: https://github.com/Mu2e/Offline/blob/main/EventGenerator/src/GeneratorPlots_module.cc . Perhaps this can be re-purposed for the RPC too.

kutschke commented 2 weeks ago

I think that will work. It's an extra step to make plots from the TTree but that's easy to do and more flexible that making plots in code. Please remove the histograms from RPCGun_modules. I will merge #1341 now and you can start a new PR to make this change.

sophiemiddleton commented 2 weeks ago

Thanks, I will put in another PR soon with the plots removed