search

Mu2e / Production

Scripts and fcl for collaboration production procedures
Apache License 2.0
0 stars 33 forks source link

Normalizations #298

Closed sophiemiddleton closed 8 months ago

sophiemiddleton commented 8 months ago

Further work on the ensembling scripts, tested with single files (DIOtail, CE, Cosmics, IPAMichel) and produced meaningful output, although full validation to follow

there will be further PRs to improve these scripts but since this is a good checkpoint I would like to merge this in now before making further changes

FNALbuild commented 8 months ago

Hi @sophiemiddleton, You have proposed changes to files in these packages:

which require these tests: build.

@Mu2e/write have access to CI actions on MDC2024.

:hourglass: The following tests have been triggered for c7dabf6f3319e8e7138d81164cc73cbf3a803df6: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild commented 8 months ago

:umbrella: The build tests failed for c7dabf6f3319e8e7138d81164cc73cbf3a803df6.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged c7dabf6f3319e8e7138d81164cc73cbf3a803df6 at b7a9a26414cb1736dd2ee427d6c2a29a78e7ac66
build (prof) :white_check_mark: Log file. Build time: 11 min 06 sec
ceSimReco :x: Log file. Return Code 90.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :x: Log file. Return Code 90.
cosmicOffSpill :x: Log file. Return Code 90.
ceSteps :white_check_mark: Log file.
ceDigi :x: Log file. Return Code 90.
muDauSteps :white_check_mark: Log file.
ceMix :x: Log file. Return Code 90.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :white_check_mark: TODO (0) FIXME (0) in 0 files
clang-tidy :white_check_mark: 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at c7dabf6f3319e8e7138d81164cc73cbf3a803df6 after being merged into the base branch at b7a9a26414cb1736dd2ee427d6c2a29a78e7ac66.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

kutschke commented 8 months ago

@gianipez Please take a look at the error messages from this PR of Sophie's. In your new scheme, what is the correct replacement for `

include "Offline/Trigger/fcl/prolog_trigger.fcl"

`

gianipez commented 8 months ago

Hi @kutschke @sophiemiddleton ,

There is not a 1-1 substitution that can take place here. Please, take a look at how it was done in the following file: https://github.com/Mu2e/Production/blob/main/JobConfig/digitize/OnSpill.fcl

brownd1978 commented 8 months ago

As part of the migration to mu2e_trig_config that file was restructured in a way that's incompatible with the shell script used to create functional job fcl (Production/Scripts/gen_Digitize.sh). I'm sorry I missed that reviewing the PR, otherwise we could have had this discussion before things were broken. I have not yet understood why this restructuring was necessary.

On Mon, Feb 26, 2024 at 3:27 PM Gianantonio Pezzullo < @.***> wrote:

Hi @kutschke https://github.com/kutschke @sophiemiddleton https://github.com/sophiemiddleton ,

There is not a 1-1 substitution that can take place here. Please, take a look at how it was done in the following file: https://github.com/Mu2e/Production/blob/main/JobConfig/digitize/OnSpill.fcl

— Reply to this email directly, view it on GitHub https://github.com/Mu2e/Production/pull/298#issuecomment-1965511706, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAH57434R2ZLZYX6BFYQWLYVUK7TAVCNFSM6AAAAABDZFWBD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSNRVGUYTCNZQGY . You are receiving this because you are on a team that was mentioned.Message ID: @.***>

-- David Brown @.*** Office Phone (510) 486-7261 Lawrence Berkeley National Lab M/S 50R5008 (50-6026C) Berkeley, CA 94720

kutschke commented 8 months ago

@sophiemiddleton a gentle reminder that there is a request from me that I would like addressed before I merge.

sophiemiddleton commented 8 months ago

I made the changes

sophiemiddleton commented 8 months ago

I am going to put in a general PR on the main branch and then we will rebase the MDC2024 branch with that and all the intermediate PRs included

brownd1978 commented 8 months ago

That sounds right. For now we should continue to develop on main. We can merge those commits back to MDC2024 later hour maybe just restart it from fresh).

David Brown @.*** Office Phone (510) 486-7261 Lawrence Berkeley National Lab M/S 50R5008 (50-6026C) Berkeley, CA 94720

On Wed, Mar 6, 2024 at 05:46 Sophie Middleton @.***> wrote:

I am going to put in a general PR on the main branch and then we will rebase the MDC2024 branch with that and all the intermediate PRs included

— Reply to this email directly, view it on GitHub https://github.com/Mu2e/Production/pull/298#issuecomment-1980912640, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAH575TIQXAUI446ITQMU3YW4M3VAVCNFSM6AAAAABDZFWBD6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSOBQHEYTENRUGA . You are receiving this because you are on a team that was mentioned.Message ID: @.***>