search

Mu2e / Production

Scripts and fcl for collaboration production procedures
Apache License 2.0
0 stars 33 forks source link

Latest progress on ensembles scripts #328

Closed sophiemiddleton closed 1 month ago

sophiemiddleton commented 2 months ago

PR contains new scripts to help produce ensembles

FNALbuild commented 2 months ago

Hi @sophiemiddleton, You have proposed changes to files in these packages:

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

:hourglass: The following tests have been triggered for fd1e2ef0b8ffb371b4b1bc9e910f15a8f85044ae: build (Build queue has 1 jobs)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild commented 2 months ago

:bangbang: It was not possible to prepare the workspace for this test. This is often caused by merge conflicts - please check and try again.

> git diff --check | grep -i conflict
CampaignConfig/mdc2020_DIOTail.ini:17: leftover conflict marker
CampaignConfig/mdc2020_DIOTail.ini:20: leftover conflict marker
CampaignConfig/mdc2020_DIOTail.ini:23: leftover conflict marker
CampaignConfig/mdc2020_celeadinglog.ini:17: leftover conflict marker
CampaignConfig/mdc2020_celeadinglog.ini:20: leftover conflict marker
CampaignConfig/mdc2020_celeadinglog.ini:23: leftover conflict marker
CampaignConfig/mdc2024_ensembles.ini:17: leftover conflict marker
CampaignConfig/mdc2024_ensembles.ini:20: leftover conflict marker
CampaignConfig/mdc2024_ensembles.ini:23: leftover conflict marker
Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :x: fd1e2ef0b8ffb371b4b1bc9e910f15a8f85044ae into ab19ec373cbd8f96d78c81e6f9763de714a10ccd merge failed
sophiemiddleton commented 2 months ago

I fixed those merge conflicts, sorry for delay

sophiemiddleton commented 2 months ago

Dave, there is an overlap....but the difference is that the gen_Primary.sh still uses gen fcl while gen_Primary2024 was part of my original work doing the fclless, so it uses jobdef. Of course gen_Primary should also be updated in the same way. gen_Primary2024....that is already in Mu2e but inside the fclless dir. Iwill remove it, in my next round I will change gen_Primary to use the fclless tools

sophiemiddleton commented 2 months ago

I will remove the example fcl since it seems to be causing issues.

sophiemiddleton commented 2 months ago

Hi Dave, I will be away at ICHEP until 26th July following the review. I will get back to this PR when I return.

sophiemiddleton commented 1 month ago

@brownd1978 @bonventre I have carried out Dave's requested changes...Richie did you have any further suggestions. I will draft out a table design and send it to you.

I will soon put in another PR with changes for the RPC campaign

brownd1978 commented 1 month ago

@FNALbuild run build test

FNALbuild commented 1 month ago

:hourglass: The following tests have been triggered for 1681fb0e586538e7cb7bebe7015e3f3a8bb28950: build (Build queue is empty)

FNALbuild commented 1 month ago

:sunny: The build tests passed at 1681fb0e586538e7cb7bebe7015e3f3a8bb28950.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged 1681fb0e586538e7cb7bebe7015e3f3a8bb28950 at 18ba4b951dea8c5195231595e2628c0ce0799572
build (prof) :white_check_mark: Log file. Build time: 08 min 25 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :white_check_mark: TODO (0) FIXME (0) in 0 files
clang-tidy :white_check_mark: 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at 1681fb0e586538e7cb7bebe7015e3f3a8bb28950 after being merged into the base branch at 18ba4b951dea8c5195231595e2628c0ce0799572.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

sophiemiddleton commented 1 month ago

Any updates on merging this?

brownd1978 commented 1 month ago

@FNALbuild run build test

FNALbuild commented 1 month ago

:hourglass: The following tests have been triggered for caa6f9e58f5900d01b5488b155ed7138ddc80e84: build (Build queue is empty)

FNALbuild commented 1 month ago

:sunny: The build tests passed at caa6f9e58f5900d01b5488b155ed7138ddc80e84.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged caa6f9e58f5900d01b5488b155ed7138ddc80e84 at 18ba4b951dea8c5195231595e2628c0ce0799572
build (prof) :white_check_mark: Log file. Build time: 04 min 11 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :white_check_mark: TODO (0) FIXME (0) in 0 files
clang-tidy :white_check_mark: 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at caa6f9e58f5900d01b5488b155ed7138ddc80e84 after being merged into the base branch at 18ba4b951dea8c5195231595e2628c0ce0799572.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.