search

Mu2e / Production

Scripts and fcl for collaboration production procedures
Apache License 2.0
0 stars 34 forks source link

Fix some bugs #338

Closed brownd1978 closed 3 months ago

brownd1978 commented 3 months ago

Correct the example invocation. Replace samweb with with samListLocations, as the former gives all locations (tape and persistent, tape first) while the latter preferentialy picks the persistent location if available.

This script needs more work: replacing generate_fcl with mu2ejobdef, etc. I also don't see the need for the 'tag' variable, and I suggest getting rid of the 2nd campaign instance. I think keeping the campaign the same as the one used to generate stopped particles will make it easier for consumers to understand the provenance. These should be addressed in subsequent PRs.

FNALbuild commented 3 months ago

Hi @brownd1978, You have proposed changes to files in these packages:

which require these tests: build.

@Mu2e/fnalbuild-users, @Mu2e/write have access to CI actions on main.

:hourglass: The following tests have been triggered for f30900af9d305547d1f50c7e09a59dcc504c4339: build (Build queue has 1 jobs)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild commented 3 months ago

:sunny: The build tests passed at f30900af9d305547d1f50c7e09a59dcc504c4339.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged f30900af9d305547d1f50c7e09a59dcc504c4339 at 87e09bd0c025369be1f50cf156c8b1c6d8cffb1d
build (prof) :white_check_mark: Log file. Build time: 04 min 13 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :white_check_mark: TODO (0) FIXME (0) in 0 files
clang-tidy :white_check_mark: 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at f30900af9d305547d1f50c7e09a59dcc504c4339 after being merged into the base branch at 87e09bd0c025369be1f50cf156c8b1c6d8cffb1d.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

kutschke commented 3 months ago

@brownd1978 Is this an example of a PR that was automatically marked draft but should be marked ready for review? I read all of your second para as work for future PRs. Is that what you meant?