search

Mu2e / Production

Scripts and fcl for collaboration production procedures
Apache License 2.0
0 stars 34 forks source link

new pion campaign #356

Closed sophiemiddleton closed 3 weeks ago

sophiemiddleton commented 1 month ago

Not final, this shows some thoughts on where to add the new pion stage nad changes needed to primary.

FNALbuild commented 1 month ago

Hi @sophiemiddleton, You have proposed changes to files in these packages:

which require these tests: build.

@Mu2e/write, @Mu2e/fnalbuild-users have access to CI actions on main.

:hourglass: The following tests have been triggered for dd96baaa18e0d4e5288ee8765def1c5c7a5e9222: build (Build queue is empty)

About FNALbuild. Code review on Mu2e/Offline.

FNALbuild commented 1 month ago

:sunny: The build tests passed at dd96baaa18e0d4e5288ee8765def1c5c7a5e9222.

Test Result Details
test with :white_check_mark: Command did not list any other PRs to include
merge :white_check_mark: Merged dd96baaa18e0d4e5288ee8765def1c5c7a5e9222 at 52cac23aeda50b03c4502430bbff26c6aab93415
build (prof) :white_check_mark: Log file. Build time: 06 min 03 sec
ceSimReco :white_check_mark: Log file.
g4test_03MT :white_check_mark: Log file.
transportOnly :white_check_mark: Log file.
POT :white_check_mark: Log file.
g4study :white_check_mark: Log file.
cosmicSimReco :white_check_mark: Log file.
cosmicOffSpill :white_check_mark: Log file.
ceSteps :white_check_mark: Log file.
ceDigi :white_check_mark: Log file.
muDauSteps :white_check_mark: Log file.
ceMix :white_check_mark: Log file.
rootOverlaps :white_check_mark: Log file.
g4surfaceCheck :white_check_mark: Log file.
FIXME, TODO :white_check_mark: TODO (0) FIXME (0) in 0 files
clang-tidy :white_check_mark: 0 errors 0 warnings

N.B. These results were obtained from a build of this Pull Request at dd96baaa18e0d4e5288ee8765def1c5c7a5e9222 after being merged into the base branch at 52cac23aeda50b03c4502430bbff26c6aab93415.

For more information, please check the job page here. Build artifacts are deleted after 5 days. If this is not desired, select Keep this build forever on the job page.

sophiemiddleton commented 3 weeks ago

Can this be merged? It would be good to get a production sample of the filtered pions and rpc for the official ensemble

brownd1978 commented 3 weeks ago

Are you planning to present this at the simulation meeting? How should I interpret the questions you (Sophie) put into the comments? Do those need to be resolved before merging?

sophiemiddleton commented 3 weeks ago

Yes, my comments were more when it was a draft. Everything can go in now.

I am busy this week. I am not planning to present tomorrow as I havent had time to prepare slides. I think this can be merged without final validation as it doesnt alter anything only updates it I have ran it locally and it doesnt break anything. Once we have Production RPC samples I can use those to do the final validation. If that's OK? I have ran some small examples my self but there are so few pions in the final sample that doing the fit you describe is not so easy. I will look at just the RPC samples to verify that they are correct and then look at the ensembles.

brownd1978 commented 3 weeks ago

It's fine to present final validation after the merge. The goal of validation is to catch problems early, it should facilitate production, not hamper it.

On Tue, Nov 5, 2024 at 10:17 AM Sophie Middleton @.***> wrote:

Yes, my comments were more when it was a draft. Everything can go in now.

I am busy this week. I am not planning to present tomorrow as I havent had time to prepare slides. I think this can be merged without final validation as it doesnt alter anything only updates it I have ran it locally and it doesnt break anything. Once we have Production RPC samples I can use those to do the final validation. If that's OK? I have ran some small examples my self but there are so few pions in the final sample that doing the fit you describe is not so easy. I will look at just the RPC samples to verify that they are correct and then look at the ensembles.

— Reply to this email directly, view it on GitHub https://github.com/Mu2e/Production/pull/356#issuecomment-2457866733, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAH57ZKCAJ7KBV3BCUAIWDZ7EDS3AVCNFSM6AAAAABQKQ7OHOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINJXHA3DMNZTGM . You are receiving this because you are on a team that was mentioned.Message ID: @.***>

-- David Brown @.*** Office Phone (510) 486-7261 Lawrence Berkeley National Lab M/S 50R5008 (50-6026C) Berkeley, CA 94720

sophiemiddleton commented 3 weeks ago

Yes sounds good. I agree we need to check everything makes sense