search

Mu2e / REve

Eve-7 based event display
Apache License 2.0
0 stars 11 forks source link

Introduce eventid filtering into the basic REve sequence #143

Closed brownd1978 closed 4 months ago

brownd1978 commented 4 months ago

EIDFilter allows one to display a selected subset of events in a collection. By setting the list to ::* the behavior reverts to the current default (no filtering). REve should be configured to select events by default. Note EIDFilter replaces the (incomplete) functionality of the run and event selection graphical input boxes, which are missing the subrun selection. Those should be removed in favor of EIDFilter.

sophiemiddleton commented 4 months ago

@brownd1978 is this the PR you put in before? The GUI event selection was sort an "under development" level feature. Its still on my radar, but I think the fcl soluton is OK. I still want to enhance the GUI but perhaps an event filter isnt the best way, if you think .fcl.

brownd1978 commented 4 months ago

Yes this predates that PR. I think factorizing event selection using standard existing tech (filters) is the right answer.

On Mon, May 6, 2024 at 5:37 PM Sophie Middleton @.***> wrote:

@brownd1978 https://github.com/brownd1978 is this the PR you put in before? The GUI event selection was sort an "under development" level feature. Its still on my radar, but I think the fcl soluton is OK. I still want to enhance the GUI but perhaps an event filter isnt the best way, if you think .fcl.

— Reply to this email directly, view it on GitHub https://github.com/Mu2e/REve/issues/143#issuecomment-2097150437, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAH5722JTCIFZ7Y6MTA7MDZBAO4DAVCNFSM6AAAAABGN5M2S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJXGE2TANBTG4 . You are receiving this because you were mentioned.Message ID: @.***>

-- David Brown @.*** Office Phone (510) 486-7261 Lawrence Berkeley National Lab M/S 50R5008 (50-6026C) Berkeley, CA 94720

sophiemiddleton commented 4 months ago

Ok, I'll close this. I need to look into some of the filtering in more detail. I'm also hoping to add some filtering on the GUI, but I'm not sure how doable that is

brownd1978 commented 4 months ago

Sorry I misspoke, this issue is still outstanding. What was implemented was an isolated example, this issue asks for a central sequence so that all downstream examples would incorporate event filtering.

On Tue, May 7, 2024 at 9:42 AM Sophie Middleton @.***> wrote:

Ok, I'll close this. I need to look into some of the filtering in more detail. I'm also hoping to add some filtering on the GUI, but I'm not sure how doable that is

— Reply to this email directly, view it on GitHub https://github.com/Mu2e/REve/issues/143#issuecomment-2098878313, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAH57YDJGS4U42PAEKN6PTZBD76NAVCNFSM6AAAAABGN5M2S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJYHA3TQMZRGM . You are receiving this because you were mentioned.Message ID: @.***>

-- David Brown @.*** Office Phone (510) 486-7261 Lawrence Berkeley National Lab M/S 50R5008 (50-6026C) Berkeley, CA 94720

kutschke commented 4 months ago

Maybe the standard fcl for the event display should include a filter that by default passes everything. Then we can write jobs that #include the base fcl and override the filter. One example would be a filter that passes events on an event list. Another could be a filter that runs on raw data files and asks for events with certain trigger bits. And any use could add an arbitrary filter.

brownd1978 commented 4 months ago

On Tue, May 7, 2024 at 11:39 AM Rob Kutschke @.***> wrote:

Maybe the standard fcl for the event display should include a filter that by default passes everything. Then we can write jobs that #include the base fcl and override the filter. One example would be a filter that passes events on an event list. Another could be a filter that runs on raw data files and asks for events with certain trigger bits. And any use could add an arbitrary filter.

Thats exactly what the example does.

— Reply to this email directly, view it on GitHub https://github.com/Mu2e/REve/issues/143#issuecomment-2099075656, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAH572OMCOKOX3BJZY76YLZBENXNAVCNFSM6AAAAABGN5M2S2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJZGA3TKNRVGY . You are receiving this because you were mentioned.Message ID: @.***>

-- David Brown @.*** Office Phone (510) 486-7261 Lawrence Berkeley National Lab M/S 50R5008 (50-6026C) Berkeley, CA 94720