Mu2e / TrkAna

Track-based analysis TTree maker working in the art framework
Apache License 2.0
2 stars 20 forks source link

Problem with missing trigger_paths/end_paths when using mu2ejobdef with TrkAna. #169

Closed sam-grant closed 3 months ago

sam-grant commented 3 months ago

Attempts to set up a grid submission using TrkAna fcl files with mu2ejobdef will result in an error relating to the fact that physics.trigger_pathsandphysics.end_paths are not defined.

For example, when I use the the following template fcl (run.fcl)

#include "TrkAna/fcl/TrkAnaExtracted.fcl"
services.DbService.purpose: CosmicCRY_best
services.DbService.version: v1_3

to generate a tarball for grid submission, using with the command

mu2ejobdef --embed run.fcl --override-output-description --auto-description --setup /cvmfs/mu2e.opensciencegrid.org/Musings/TrkAna/v05_03_00/setup.sh --auto-description --dsconf MDC2020ae_best_v1_3 --inputs file_list.txt --merge-factor=1

the result is

Error: please define physics.trigger_paths in the fcl file..

You can get around this by appending

physics.trigger_paths: [ TrkAnaTrigPath ] 
physics.end_paths: [ TrkAnaEndPath ]

to the template fcl, but a more permanent solution might be to include these paths in the source fcl files themselves.

sam-grant commented 3 months ago

(I'm working on a PR with a possible solution.)

AndrewEdmonds11 commented 3 months ago

Now fixed in #171

sam-grant commented 3 months ago

Just to note, the fix only applies to TrkAnaReco.fcl and TrkAnaExtracted.fcl at the moment.

AndrewEdmonds11 commented 3 months ago

Good point. I'll add an issue to generally tidy up the other fcl files

sam-grant commented 3 months ago

I can make the issue and PR if that's easier? There were just a couple of cases where I wasn't sure if what I was doing made sense and wanted to clarify before making a changes.