Mu2e / TrkAna

Track-based analysis TTree maker working in the art framework
Apache License 2.0
1 stars 19 forks source link

Upgrade python util to use SurfaceId enum #180

Open AndrewEdmonds11 opened 3 weeks ago

AndrewEdmonds11 commented 3 weeks ago

At the moment, we need to know the magic numbers to get specific surfaces. It would be better if we could use the SurfaceId enum directly in the same what that we can use the enum of ProcessCode (see https://github.com/Mu2e/TrkAna/blob/main/tutorial/pages/genealogy.md). This probably means that SurfaceId needs to be added to pywrap but we have the ProcessCode example we can follow

brownd1978 commented 3 weeks ago

One possible complication is that SurfaceId has both an enum and an index component. The index is to give unique identities to (say) a particular foil of the stopping target.

On Mon, Jul 8, 2024 at 8:16 AM Andrew Edmonds @.***> wrote:

At the moment, we need to know the magic numbers to get specific surfaces. It would be better if we could use the SurfaceId enum directly in the same what that we can use the enum of ProcessCode (see https://github.com/Mu2e/TrkAna/blob/main/tutorial/pages/genealogy.md). This probably means that SurfaceId needs to be added to pywrap but we have the ProcessCode example we can follow

— Reply to this email directly, view it on GitHub https://github.com/Mu2e/TrkAna/issues/180, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABAH577T7YJDRCZYVNLPWATZLKULBAVCNFSM6AAAAABKRBWU3KVHI2DSMVQWIX3LMV43ASLTON2WKOZSGM4TKOJSGA4TAOA . You are receiving this because you are subscribed to this thread.Message ID: @.***>

-- David Brown @.*** Office Phone (510) 486-7261 Lawrence Berkeley National Lab M/S 50R5008 (50-6026C) Berkeley, CA 94720

kutschke commented 3 weeks ago

See Offline PR 1300 (https://github.com/Mu2e/Offline/pull/1300)