MuMech / MechJeb2

MechJeb2 - KSP mod
Other
994 stars 250 forks source link

Final landing burn triggers too late when TWR is greater than 2 #1161

Open jrodrigv opened 5 years ago

jrodrigv commented 5 years ago

Hi,

I have been experiencing this problem for a very long time. I have never reported it before because I always manage to reduce the TWR at landing to something like 1.7-1.8 which seems more Mechjeb friendly.

The problem seems to be that Mechjeb is not taking into account the time it takes for an engine to produce thrust after the landing guidance begin to increase the vessel throttle (from idle).

I can attach demo video if it helps (I'm using RSS/RO)

From a development point of view I think this time can be measure empirically (in case it is not defined as part of the ModuleEngines), during launch or doing a quick burn test during landing.

jrodrigv commented 5 years ago

I can confirm this will only happen with RealFuels/RealismOverhaul due to specific patches that change the way the throttling response works.

Gordon-Dry commented 5 years ago

Is it because of such thing like useEngineResponseTime, engineAccelerationSpeed?

jrodrigv commented 5 years ago

Yes, exactly :)

lamont-granquist commented 5 years ago

relevant bit of existing code that could get reused:

https://github.com/MuMech/MechJeb2/blob/63b2a027a8c84bac2206442b084168f2e27ed11d/MechJeb2/MechJebModuleThrustController.cs#L301-L311