Update VesselState.cs - Githubissues

MuMech / MechJeb2

MechJeb2 - KSP mod

Other

982 stars 250 forks source link

Update VesselState.cs #1873

Closed Starwaster closed 3 months ago

Starwaster commented 3 months ago

There's a bug reported #1860 where RCS keeps turning on when unwanted for non-Real Fuels users and requires turning off AutoRCSUllaging. This may be enough to fix it but this could use other sanity checks elsewhere. Also, RCS ullaging should either

Check for Core.Attitude.RCS_auto = true or else don't enable RCS!
Put in code to turn RCS back off when ullaging is completed.

lamont-granquist commented 3 months ago

sorry been busy and i didn't check to see how easy this one was.

lamont-granquist commented 3 months ago

I think i'd be okay with checking RCS_auto but does it persist?

And for RF it'd be nice to force it to true rather than false somehow.

Starwaster commented 3 months ago

I think i'd be okay with checking RCS_auto but does it persist?

And for RF it'd be nice to force it to true rather than false somehow.

Pretty sure it does not persist. Not last time I checked and I don't think that ever changed.

lamont-granquist commented 3 months ago

Yeah for RO/RF that should really persist, probably should persist anyway.

Because really in RO/RF with PVG coasts I want to make it pretty difficult to disable RCS, rather than having it easy to forget to enable it all the time.