Fix ToSI for floats - Githubissues

MuMech / MechJeb2

MechJeb2 - KSP mod

Other

982 stars 250 forks source link

Fix ToSI for floats #1892

Closed Nazfib closed 1 month ago

Nazfib commented 1 month ago

Fix float.ToSI to match the changes to double.ToSI in 02fab0d671985f54d3a22d769affa904db3294b6

The float version is only used at https://github.com/MuMech/MechJeb2/blob/6150a7869e634d8307343fc32c0a1e10ebf21c2e/MechJeb2/MechJebModuleInfoItems.cs#L436 https://github.com/MuMech/MechJeb2/blob/6150a7869e634d8307343fc32c0a1e10ebf21c2e/MechJeb2/MechJebModuleTranslatron.cs#L125 https://github.com/MuMech/MechJeb2/blob/6150a7869e634d8307343fc32c0a1e10ebf21c2e/MechJeb2/MechJebModuleWaypointWindow.cs#L183

All three are relatively obscure, which is probably why it hasn't been noticed before.

lamont-granquist commented 1 month ago

yep, probably missed those in the noise.