MuckRock / documentcloud-frontend

DocumentCloud's front end source code - Please report bugs, issues and feature requests to info@documentcloud.org
https://www.documentcloud.org
GNU Affero General Public License v3.0
15 stars 5 forks source link

Consolidate fixtures and handlers #490

Closed allanlasser closed 6 months ago

allanlasser commented 6 months ago

Since fixtures and handlers are only used by stories and tests, this PR should be fine to merge once our checks pass.

After this merges and becomes base for sveltekit, I will open a separate PR against that branch incorporating the fixtures and handlers we've added in that branch.

netlify[bot] commented 6 months ago

Deploy Preview for documentcloud-frontend ready!

Name Link
Latest commit d99c5e2a23228c32c44aa6ff176dd56741a5b518
Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/660acfd8153ab2000899c11a
Deploy Preview https://deploy-preview-490.muckcloud.com
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 6 months ago

Coverage report

St.:grey_question:
Category Percentage Covered / Total
πŸ”΄ Statements
2.8% (+0% πŸ”Ό)
1978/70691
πŸ”΄ Branches
3.04% (-0% πŸ”»)
925/30453
πŸ”΄ Functions
3.22% (+0.01% πŸ”Ό)
503/15642
πŸ”΄ Lines
2.84% (+0% πŸ”Ό)
1796/63189
Show new covered files 🐣
|
St.:grey_question:
| File | Statements | Branches | Functions | Lines | | :-: | :- | :- | :- | :- | :- | | πŸ”΄ |
`...` / common.ts
| 0% | 100% | 100% | 0% | | πŸ”΄ |
`...` / documents.ts
| 0% | 100% | 100% | 0% | | πŸ”΄ |
`...` / projects.ts
| 0% | 100% | 100% | 0% | | πŸ”΄ |
`...` / addons.ts
| 0% | 100% | 100% | 0% | | πŸ”΄ |
`...` / accounts.ts
| 0% | 100% | 0% | 0% | | πŸ”΄ |
`...` / documents.ts
| 0% | 100% | 0% | 0% | | πŸ”΄ |
`...` / projects.ts
| 0% | 100% | 100% | 0% | | πŸ”΄ |
`...` / utils.ts
| 0% | 0% | 0% | 0% | | πŸ”΄ |
`...` / addons.ts
| 0% | 100% | 0% | 0% | | πŸ”΄ |
`...` / accounts.ts
| 0% | 100% | 100% | 0% |

Test suite run success

84 tests passing in 16 suites.

Report generated by πŸ§ͺjest coverage report action from d99c5e2a23228c32c44aa6ff176dd56741a5b518

eyeseast commented 6 months ago

There are a bunch of type imports in here that need the type annotation. I'll go through and add them.

eyeseast commented 6 months ago

I think I got all the type imports now. Please double check.