search

MuckRock / documentcloud-frontend

DocumentCloud's front end source code - Please report bugs, issues and feature requests to info@documentcloud.org
https://www.documentcloud.org
GNU Affero General Public License v3.0
15 stars 5 forks source link

Decide if we should be more nuanced with document types #500

Open eyeseast opened 6 months ago

eyeseast commented 6 months ago

In the spirit of keeping things simple and composed, what if we just used Page<Document> in places where we're using DocumentResults? If we expect the search page to return other properties, then making a SearchResults<Document> type would be another good option.

_Originally posted by @allanlasser in https://github.com/MuckRock/documentcloud-frontend/pull/494#discussion_r1544647821_