Closed eyeseast closed 2 months ago
Name | Link |
---|---|
Latest commit | ba89e3fdb34c8aba0015b3e4fedd4fbde707dce5 |
Latest deploy log | https://app.netlify.com/sites/documentcloud-frontend/deploys/663128c6173aa80008a31628 |
Deploy Preview | https://deploy-preview-532.muckcloud.com |
Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
To edit notification comments on pull requests, go to your Netlify site configuration.
Awesome start. Initial thoughts:
@font-face
.src/common/Dropdown2
component for menu logic (that's what I used in the global nav). It has a prop control the placement of the menu in relation to the menu button./text
in the path is better. Both approaches are equivalent, so having a stated reason will help with #522 Do we need to render notes, redactions, or other edits onto the text?
Status | Category | Percentage | Covered / Total |
---|---|---|---|
🔵 | Lines | 37.9% | 2892 / 7630 |
🔵 | Statements | 37.9% | 2892 / 7630 |
🔵 | Functions | 26.87% | 43 / 160 |
🔵 | Branches | 47.53% | 106 / 223 |
File | Stmts | % Branch | % Funcs | % Lines | Uncovered Lines |
---|---|---|---|---|---|
Changed Files | |||||
src/lib/api/documents.ts | 82.29% | 79.31% | 83.33% | 82.29% | 27-55, 61-90, 120-121, 125-126, 132-133, 166-167, 228 |
src/lib/api/types.d.ts | 0% | 0% | 0% | 0% | 1-226 |
src/lib/components/documents/TextPage.svelte | 0% | 0% | 0% | 0% | 1-55 |
src/routes/app/+page.svelte | 0% | 0% | 0% | 0% | 1-119 |
src/routes/app/add-ons/+page.svelte | 0% | 0% | 0% | 0% | 1-131 |
src/routes/app/projects/+page.svelte | 0% | 0% | 0% | 0% | 1-64 |
src/routes/app/projects/[id]-[slug]/+page.svelte | 0% | 0% | 0% | 0% | 1-112 |
src/routes/documents/[id]-[slug]/+layout.ts | 0% | 0% | 0% | 0% | 1-43 |
src/routes/documents/[id]-[slug]/+page.svelte | 0% | 0% | 0% | 0% | 1-177 |
src/routes/documents/[id]-[slug]/+page.ts | 0% | 0% | 0% | 0% | 1-27 |
If the text view is a state of the document, then it may be better as a search param than a path. If the view is a resource of the document, then having /text in the path is better. Both approaches are equivalent, so having a stated reason will help with https://github.com/MuckRock/documentcloud-frontend/issues/522
Text has to be fetched on its own, after we fetch the document data (because we need document.asset_url
), so that makes me think it's better giving it a dedicated URL so we can fetch it server-side.
We have four document modes:
Those could all be at the same URL with query params to switch. Text is the only resource that needs to be fetched on its own.
Let's merge this and then deal with the page hash when we do pagination, which I think will end up addressing that.
I'm not sure what's happening with mode
and the initial state.
https://deploy-preview-532.muckcloud.com/documents/20006357-reportersguide/?mode=text