search

MuckRock / documentcloud-frontend

DocumentCloud's front end source code - Please report bugs, issues and feature requests to info@documentcloud.org
https://www.documentcloud.org
GNU Affero General Public License v3.0
15 stars 5 forks source link

Remove unnecessary Paginator component #550

Closed allanlasser closed 1 month ago

allanlasser commented 1 month ago

While reviewing #542, I noticed that we have two pagination components in this branch despite reconciling them previously.

The $lib/components/common/Paginator.svelte component was only used in the Project embed, so I've replaced it with the @/common/Paginator.svelte that is used by all other components.

netlify[bot] commented 1 month ago

Deploy Preview for documentcloud-frontend ready!

Name Link
Latest commit 4d45bae37084e79379c893ca2330b86823336289
Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/664b7f964d08780008ca39b8
Deploy Preview https://deploy-preview-550.muckcloud.com
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

github-actions[bot] commented 1 month ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 38.27% 2990 / 7812
🔵 Statements 38.27% 2990 / 7812
🔵 Functions 26.7% 43 / 161
🔵 Branches 47.78% 108 / 226
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/routes/(embed)/projects/[project_id]/+page.svelte 0% 0% 0% 0% 1-79
Generated in workflow #121