MuckRock / documentcloud-frontend

DocumentCloud's front end source code - Please report bugs, issues and feature requests to info@documentcloud.org
https://www.documentcloud.org
GNU Affero General Public License v3.0
15 stars 5 forks source link

Render Modals in Portals #582

Closed allanlasser closed 1 week ago

allanlasser commented 1 week ago

This renders Modals in a new Portal component, following the proposal made in #578. This approach to modals does not require global context or any state management. The parent calling component needs to simply track whether it wants the modal to be displayed, or not.

To fix:

github-actions[bot] commented 1 week ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 30.27% 3370 / 11130
🔵 Statements 30.27% 3370 / 11130
🔵 Functions 31.68% 64 / 202
🔵 Branches 54.21% 180 / 332
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/lib/components/layouts/MainLayout.svelte 0% 0% 0% 0% 1-246
src/lib/components/layouts/Modal.svelte 0% 0% 0% 0% 1-104
src/lib/components/layouts/Portal.svelte 0% 0% 0% 0% 1-29
src/routes/documents/[id]-[slug]/+layout.svelte 0% 0% 0% 0% 1-81
src/routes/documents/[id]-[slug]/redact/+page.svelte 0% 0% 0% 0% 1-132
src/routes/documents/[id]-[slug]/sidebar/Actions.svelte 0% 0% 0% 0% 1-153
src/routes/documents/[id]-[slug]/sidebar/DocumentMetadata.svelte 0% 0% 0% 0% 1-85
Generated in workflow #188
netlify[bot] commented 1 week ago

Deploy Preview for documentcloud-frontend ready!

Name Link
Latest commit 8fc54806a8850abf4180f986ad12f74f2c2b2d59
Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/667ecc529f091300087ba3ad
Deploy Preview https://deploy-preview-582.muckcloud.com
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.