MuckRock / documentcloud-frontend

DocumentCloud's front end source code - Please report bugs, issues and feature requests to info@documentcloud.org
https://www.documentcloud.org
GNU Affero General Public License v3.0
15 stars 5 forks source link

Handles undefined user.name #711

Closed allanlasser closed 1 week ago

allanlasser commented 1 week ago

Closes #706

Uses our getUserName helper function to avoid directly accessing user.name and always return a string.

github-actions[bot] commented 1 week ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 22.48% 6327 / 28138
🔵 Statements 22.48% 6327 / 28138
🔵 Functions 39.88% 134 / 336
🔵 Branches 57.16% 335 / 586
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/lib/api/documents.ts 97.88% 88.67% 100% 97.88% 130-131, 148-154, 158-159, 458-460
src/lib/components/accounts/UserMenu.svelte 100% 75% 0% 100%
src/lib/components/documents/Note.svelte 0% 0% 0% 0% 1-341
src/lib/components/embeds/DocumentEmbed.svelte 0% 0% 0% 0% 1-64
src/lib/components/forms/ManageCollaborators.svelte 0% 0% 0% 0% 1-182
src/lib/components/forms/UserFeedback.svelte 0% 0% 0% 0% 1-213
src/lib/components/navigation/OrgMenu.svelte 0% 0% 0% 0% 1-274
src/lib/utils/search.ts 97.22% 81.81% 85.71% 97.22% 14-15
Generated in workflow #476
netlify[bot] commented 1 week ago

Deploy Preview for documentcloud-frontend ready!

Name Link
Latest commit c506cc5e204e1c8859d6c8783f3079fd6e6d2780
Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/66f430e9b3719200088a16a6
Deploy Preview https://deploy-preview-711.muckcloud.com
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.