MuckRock / documentcloud-frontend

DocumentCloud's front end source code - Please report bugs, issues and feature requests to info@documentcloud.org
https://www.documentcloud.org
GNU Affero General Public License v3.0
15 stars 5 forks source link

Fix Mobile Safari height #728

Closed allanlasser closed 1 week ago

allanlasser commented 1 week ago

Closes #694 by using dvh to adapt to changing viewport hight

This fixes the positioning of toolbars and elements, but does not go further in collapsing Mobile Safari's toolbar on scroll. That will require additional work, which I've captured as #729.

github-actions[bot] commented 1 week ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 21.45% 6346 / 29573
🔵 Statements 21.45% 6346 / 29573
🔵 Functions 39.13% 135 / 345
🔵 Branches 56.42% 338 / 599
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/lib/components/layouts/AppLayout.svelte 0% 0% 0% 0% 1-45
Generated in workflow #506
netlify[bot] commented 1 week ago

Deploy Preview for documentcloud-frontend ready!

Name Link
Latest commit cca5d31443250aaff630fb53adb22ff947ce1de1
Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/66f6d0228baea60008e1b240
Deploy Preview https://deploy-preview-728.muckcloud.com
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.