Tooltip enhancements - Githubissues

allanlasser commented 1 month ago

I opted to replace the custom logic with Floating UI for a few reasons:

We get more reliable functionality for shifting position and respecting window boundaries, with a well-tested and widely used library.
We can use Floating UI in other components, like Dropdowns, without rewriting the logic.
We can use Floating UI with <canvas> in the document viewer to enhance the interface (see #204)

github-actions[bot] commented 1 month ago

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	21.99%	6823 / 31022
🔵	Statements	21.99%	6823 / 31022
🔵	Functions	40.16%	145 / 361
🔵	Branches	58.01%	369 / 636

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/lib/components/common/AddOns.svelte	0%	0%	0%	0%	1-81
src/lib/components/common/Tooltip.svelte	100%	66.66%	100%	100%
src/lib/components/forms/DocumentUpload.svelte	100%	25%	0%	100%
src/lib/components/layouts/EmbedLayout.svelte	0%	0%	0%	0%	1-109
src/lib/components/processing/Documents.svelte	0%	0%	0%	0%	1-196
src/lib/components/viewer/toolbars/AnnotationToolbar.svelte	0%	0%	0%	0%	1-400
src/lib/components/viewer/toolbars/RedactionToolbar.svelte	0%	0%	0%	0%	1-1192

Generated in workflow #575 for commit eb0f942 by the Vitest Coverage Report Action

netlify[bot] commented 1 month ago

Name	Link
Latest commit	45b84cd19d085015eb5990bee6b287b88412c70f
Latest deploy log	https://app.netlify.com/sites/documentcloud-frontend/deploys/6706b8aa07796700089025ea
Deploy Preview	https://deploy-preview-772.muckcloud.com
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 53 Accessibility: 79 Best Practices: 83 SEO: 85 PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 1 month ago

Name	Link
Latest commit	eb0f9424592d7dcb1bc645eeb753b6b553834c67
Latest deploy log	https://app.netlify.com/sites/documentcloud-frontend/deploys/6706c0564ab666000802c5a4
Deploy Preview	https://deploy-preview-772.muckcloud.com
Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 51 Accessibility: 79 Best Practices: 83 SEO: 85 PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.