Closed allanlasser closed 4 weeks ago
github-actions[bot]
commented
1 month ago | Status | Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔵 | Lines | 23.65% | 7454 / 31514 |
| 🔵 | Statements | 23.65% | 7454 / 31514 |
| 🔵 | Functions | 41.14% | 151 / 367 |
| 🔵 | Branches | 60.66% | 418 / 689 |
netlify[bot]
commented
1 month ago | Name | Link |
|---|---|
| Latest commit | 2e51a01ec87c1996d9f15528a91ff4f0ed1e6dc8 |
| Latest deploy log | https://app.netlify.com/sites/documentcloud-frontend/deploys/67190d728d0c130008f8de2c |
| Deploy Preview | https://deploy-preview-777.muckcloud.com |
| Preview on mobile | Toggle QR Code...Use your smartphone camera to open QR code link. |
Lighthouse |
1 paths audited Performance: 39 Accessibility: 79 Best Practices: 92 SEO: 85 PWA: - View the detailed breakdown and full score reports |
To edit notification comments on pull requests, go to your Netlify site configuration.
Refactors the viewer to make its logic easier to reason about and its code more adaptable to change. Goals are cleaning up code, consolidating redundancies, and extracting pure functions.
Some of the advantages:
ViewerContext, then accessing this context from its subcomponents (with the exception of optimistic updates, but it's possible we could improve our approach and optimistically update the$page.datastore inside an action instead of returning an updated value from it).$lib/load/document.tsand navigation handling inViewerContextdeduplicates functionality between app and embed routes.ViewerContextprevents re-loading the PDF between different viewer modes, potentially resolving #565Changes include:
ViewerContextthat makes it easier to set and access data for variety of sub-componentsViewerContextdirectlyTextandTextPage*Paneinto*LayerNotesPanewithAnnotationsPaneto deduplicate rendering logicViewerContext, instead of the conditionally-renderedPDFafterNavigateandonHashChangeintoViewerContextfromsrc/routes/(app)/documents/[id]-[slug]/+page.svelteandsrc/routes/embed/documents/[id]-[slug]/+page.svelteviewerdirectory as flat as possible. Toolbars are now alongside their layers, e.g.AnnotationLayerandAnnotationToolbarare siblings.zoomstate intoViewerContextand scale/size conversion logic intolib/utils/viewerlib/utils/viewersrc/lib/components/viewer/README.mdwith a high-level overview of how it works (yay documentation)Not doing:
lib/components/viewerPDFPage.svelteandNote.svelte—there's a duplication of logic there. The render functions could also be made pure and assume it's operating on acanvasnode that's passed as an argument. (This is complex and risky enough that it should be its own issue/PR).