MuckRock / documentcloud-frontend

DocumentCloud's front end source code - Please report bugs, issues and feature requests to info@documentcloud.org
https://www.documentcloud.org
GNU Affero General Public License v3.0
18 stars 5 forks source link

Expand projects in document search results #799

Closed allanlasser closed 3 weeks ago

allanlasser commented 4 weeks ago

Closes #790

We already have the capability to display projects on document search results, but we weren't expanding them in the API request.

netlify[bot] commented 4 weeks ago

Deploy Preview for documentcloud-frontend ready!

Name Link
Latest commit 2da1a37ef1f0c3de7a60b104564354f96c8084ca
Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/671fd61982c8490008d0ee98
Deploy Preview https://deploy-preview-799.muckcloud.com
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 43
Accessibility: 79
Best Practices: 92
SEO: 85
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

netlify[bot] commented 4 weeks ago

Deploy Preview for documentcloud-frontend ready!

Name Link
Latest commit 96651eb6a54fd9ebc7cc24ddf4d28c8e696a3c4f
Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/6723b8922ea9730008469b6a
Deploy Preview https://deploy-preview-799.muckcloud.com
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 41
Accessibility: 78
Best Practices: 92
SEO: 83
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

allanlasser commented 4 weeks ago
Screenshot 2024-10-28 at 3 56 27 PM

This needs some additional wrapping and overflow handling

github-actions[bot] commented 3 weeks ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 24.3% 7922 / 32588
🔵 Statements 24.3% 7922 / 32588
🔵 Functions 42.72% 188 / 440
🔵 Branches 62.17% 480 / 772
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/lib/api/documents.ts 97.55% 87.27% 100% 97.55% 155-157, 162-163, 180-186, 190-191, 490-492
src/lib/components/documents/Access.svelte 100% 100% 100% 100%
src/lib/components/documents/DocumentListItem.svelte 55.75% 76.47% 51.38% 55.75% 60-64, 73-166, 184-193, 213-223, 229-230, 260, 274-282, 300-325, 328-334, 337-343, 347-348, 383, 390-392, 395-397, 400-401, 437-441, 453-455, 458-460, 463-464, 468-469, 501-502, 509-511, 515-517, 544-545, 552, 556-558, 574-625, 666-667, 679-680, 683, 713-714, 719-761, 809-812, 826-971, 974-983, 986-995, 1052-1053, 1056-1057, 1063-1064, 1074, 1078, 1082-1116, 1120-1131, 1135-1136, 1224-1225, 1228-1230
Generated in workflow #642 for commit 96651eb by the Vitest Coverage Report Action
eyeseast commented 3 weeks ago

Something weird happening at mobile width:

Screenshot 2024-10-30 at 9 28 22 AM
allanlasser commented 3 weeks ago

Something weird happening at mobile width

That is intentional styling for mobile, and clearly it needs some work!

eyeseast commented 3 weeks ago

Just noticed that I'm also seeing some overflow on the list view:

Screenshot 2024-10-30 at 10 16 28 AM