MuckRock / documentcloud-frontend

DocumentCloud's front end source code - Please report bugs, issues and feature requests to info@documentcloud.org
https://www.documentcloud.org
GNU Affero General Public License v3.0
18 stars 5 forks source link

Clean field description HTML #817

Closed eyeseast closed 2 weeks ago

eyeseast commented 2 weeks ago

The issue was the {@html ...} tag in Field.svelte, and the unclosed and unescaped <a> tag in the field description.

github-actions[bot] commented 2 weeks ago

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 24.77% 8350 / 33707
🔵 Statements 24.77% 8350 / 33707
🔵 Functions 44.51% 211 / 474
🔵 Branches 62.6% 529 / 845
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/lib/components/accounts/Mailkey.svelte 100% 100% 100% 100%
src/lib/components/addons/AddOnMeta.svelte 0% 0% 0% 0% 1-78
src/lib/components/inputs/Field.svelte 100% 66.66% 100% 100%
src/lib/components/navigation/Breadcrumbs.svelte 65.06% 78.26% 51.56% 65.06% 75-79, 93-95, 98-99, 103-104, 133, 145-149, 162-187, 190-196, 199-205, 209-210, 228-279, 296-300, 313-321, 325-326, 356-357, 372-379, 394-404, 407-409, 412-413, 417-420, 456-459, 472-508, 511-514, 517-519, 523-525, 568-572, 593-599, 602-604, 607-608, 645, 649-650, 654-661, 665-667, 671-672, 697-698, 701-703
src/routes/(app)/add-ons/[owner]/[repo]/+page.ts 0% 0% 0% 0% 1
src/routes/(app)/add-ons/[owner]/[repo]/[event]/+page.ts 0% 0% 0% 0% 1
Generated in workflow #683 for commit 974c6cb by the Vitest Coverage Report Action
netlify[bot] commented 2 weeks ago

Deploy Preview for documentcloud-frontend ready!

Name Link
Latest commit 974c6cb0b95c14b9b09157b9e41a36987c33eb06
Latest deploy log https://app.netlify.com/sites/documentcloud-frontend/deploys/672e20c0944fad0008381c29
Deploy Preview https://deploy-preview-817.muckcloud.com
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

Lighthouse
1 paths audited
Performance: 53
Accessibility: 85
Best Practices: 92
SEO: 91
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.