MuckRock / documentcloud-frontend

DocumentCloud's front end source code - Please report bugs, issues and feature requests to info@documentcloud.org
https://www.documentcloud.org
GNU Affero General Public License v3.0
18 stars 5 forks source link

SvelteKit DocumentCloud Menu and Page Consistency #840

Closed morisy closed 15 hours ago

morisy commented 3 days ago

We'd like to have more consistency on DocumentCloud menu items. Some concepts underlying the redesign were (please correct or clarify as needed, couldn't find this explicit in the Figma):

Right now, /documents/ /projects/ and /add-ons/ all off slight visual distinctions and different menu mappings, which I think hurts the usability more than we need to.

Consistent Action Buttons

We should have a consistent ordering and appearance (when applicable) in the "Upload Documents" section in the top right and generally on the left rail so that if a user is used to looking there for some item, it will appear there.

Image Image

For the Upload Documents action box, I'd suggest the following actions, with the asterisked actions only appearing on /projects/ pages:

Upload (or Upload to Project)

We should similarly keep the left hand side consistent, though adding Project Collaborators when on a project page but otherwise keeping the left hand menu the same.

I would suggest keeping that left hand rail for /add-on/ pages as well, and moving the Add-On pane to replace the right rail to be consistent with the initially stated left/right navigation/action distinction, while providing clearer markers for people to get back to the key area they're most likely to be interested in. I would also have the Add-Ons that don't run on documents still show the document pane for consistencies sake.

We should also be consistent in how items are capitalized. Our current style guide calls for clickable menu items to be capitalized; descriptive text should not be capitalized "Your Documents" button vs. "Your documents are safely saved." dialog. We have a place places such as Edit Metadata and Move to project in the Upload Documents dialogue area and EXPLORE by the Projects and Add-Ons menus where this convention is not followed.

allanlasser commented 20 hours ago

@morisy I've noticed some similarity in how we show search shortcuts and how GitHub shows shortcuts for filtering issues:

screenshot_2024-11-21_at_11 32 44___am_720

If we moved the document search filtering shortcuts out of the left sidebar and into a search filter dropdown, this would go further to making the left sidebar globally consistent:

Screenshot 2024-11-21 at 11 53 17 AM

Thoughts?

allanlasser commented 15 hours ago

I've forked this into three smaller issues with tighter scopes.