MuckRock / muckrock

MuckRock's source code - Please report bugs, issues and feature requests to info@muckrock.com
https://www.muckrock.com
GNU Affero General Public License v3.0
114 stars 22 forks source link

Duplicating communication via "Move" removes attachments from original page #412

Closed shawnmusgrave closed 9 years ago

shawnmusgrave commented 9 years ago

Agency sent communication with responsive attachments to this request page:

https://www.muckrock.com/foi/united-states-of-america-10/nbc-nightly-news-with-brian-williams-fcc-complaints-17459/

Documents sent were also responsive to this request:

https://www.muckrock.com/admin/foia/foiarequest/17460/

When I used "Move" with "17460, 17459", attachments were removed from MR17459 but went through successfully to MR17460. Communication text itself was still on MR17459.

shawnmusgrave commented 9 years ago

There also seems to be weird attachment duplication, but I can't figure out what the rule error is.

JPatBrown commented 9 years ago

Ran into this yesterday with the Malcolm X files - attempting to duplicate only moved attachments to the first location, and then created some (but not all) attachment duplications in the original request.

Or, I tried to move 1 w/ attachments abc to 2 and 1, and it ended up as 2abc, 1. When I tried to move the files back, I ended up with 1aaabc.

On Wed, May 20, 2015 at 12:13 PM, shawnmusgrave notifications@github.com wrote:

There also seems to be weird attachment duplication, but I can't figure out what the rule error is.

— Reply to this email directly or view it on GitHub https://github.com/MuckRock/muckrock/issues/412#issuecomment-103943734.

J. Patrick Brown Muckrock.com Twitter https://twitter.com/resentfultweet PGP http://pgp.mit.edu/pks/lookup?op=get&search=0xDD5B5B2A85B2477A m 504.400.4717 o 617.299.1832.

shawnmusgrave commented 9 years ago

Now the "Move" button is duplicating the attachments but attaching the duplicates to the original communication, rather than the version moved to the new request page:

Original request : https://www.muckrock.com/foi/united-states-of-america-10/dhs-social-media-risk-assessment-6983/

Target request : https://www.muckrock.com/foi/united-states-of-america-10/dhs-component-social-media-templates-6992/