Tag editor

[mitchelljkotler]

The tag editor on the FOIA page should have auto completion as well as allowing for multiple tags. It also shouldn't show up as being editable for users who can't edit tags for that request.

[allanlasser]

I thought I had made it so only creators and staff could edit tags—is this not the case?

On Nov 9, 2014, at 21:19, mitchelljkotler notifications@github.com wrote:

The tag editor on the FOIA page should have auto completion as well as allowing for multiple tags. It also shouldn't show up as being editable for users who can't edit tags for that request.

— Reply to this email directly or view it on GitHub.

[mitchelljkotler]

I didn't look into it closely, but it looked like I had an edit button, but could not actually edit the tags, for a request I did not own. But I am staff.

On Sun, Nov 9, 2014 at 10:16 PM, Allan Lasser notifications@github.com wrote:

I thought I had made it so only creators and staff could edit tags—is this not the case?

On Nov 9, 2014, at 21:19, mitchelljkotler notifications@github.com wrote:

The tag editor on the FOIA page should have auto completion as well as allowing for multiple tags. It also shouldn't show up as being editable for users who can't edit tags for that request.

— Reply to this email directly or view it on GitHub.

— Reply to this email directly or view it on GitHub https://github.com/MuckRock/muckrock/issues/73#issuecomment-62336092.

[allanlasser]

Fixed the problem where it wasn’t checking if user was staff, allowing tags to be entered but throwing them away: b1f6eebbdb172f737301a82065d2c602d3f13372

[allanlasser]

@mitchelljkotler I haven’t worked with the django-taggit logic at all yet, is there anything I need to know before doing something similar to this AC-L example? I’m trying to just do a straight comma-separated autocompleter without using a jQuery combobox or anything heavy like that.

[mitchelljkotler]

yeah, taggit can be weird sometimes. i guess its not urgent, but i think it would be nice to switch it to an autocomplete at some point. you can take a look at the code i have for editing tags now as an example i believe.

On Mon, Nov 10, 2014 at 12:31 PM, Allan Lasser notifications@github.com wrote:

@mitchelljkotler https://github.com/mitchelljkotler I haven’t worked with the django-taggit logic at all yet, is there anything I need to know before doing something similar to this AC-L example https://github.com/yourlabs/django-autocomplete-light/tree/stable/2.x.x/autocomplete_light/example_apps/charfield_autocomplete? I’m trying to just do a straight comma-separated autocompleter without using a jQuery combobox or anything heavy like that.

— Reply to this email directly or view it on GitHub https://github.com/MuckRock/muckrock/issues/73#issuecomment-62421057.

[allanlasser]

Ok, marking this as something to revisit after the rest of the redesign checklist is complete.

[allanlasser]

8e8969f4a492fad610fdf7bd0356eb87bbc24a38 adds autocomplete to the tag field