search

MuckRock / spotus

GNU Affero General Public License v3.0
0 stars 0 forks source link

fixes #6 #7

Open mattkiefer opened 4 years ago

mitchelljkotler commented 4 years ago

I am not up to speed with what issue is here, but this is probably not the correct fix. As the comment suggests, the code for mini-registration should be copied over from MuckRock (or ported to a common library), which I did not get to in my initial port. Just doing nothing will not work if the assignment requires you to be logged in, as there will be no user to record if you do not register for an account.

Mini Register is having someone sign up for an account while taking another action - such as completing an assignment. We just ask for their email address and automatically create a username and password for them. This is complicated by the fact that the user account needs to be created on Squarelet, so it requires an API call as opposed to just creating it in the database.

So we either need to port the mini-register code or disable requiring user's to be signed in to submit.

mattkiefer commented 4 years ago

OK, I wasn't sure where mini registration fit into this app. I may need to circle back on this next week after I sort out some scheduling things on my end.