search

MudBlazor / MudBlazor

Blazor Component Library based on Material design with an emphasis on ease of use. Mainly written in C# with Javascript kept to a bare minimum it empowers .NET developers to easily debug it if needed.
http://mudblazor.com
MIT License
7.25k stars 1.18k forks source link

Icons Request: Twitch, Tumblr, ArtStation, DeviantArt, and Pixiv #6144

Open ChristianHinko opened 1 year ago

ChristianHinko commented 1 year ago

Feature request type

Other

Component name

No response

Is your feature request related to a problem?

Custom icon strings do not integrate as nicely as the built-in Icons do; for example, custom icons may have different values for the viewBox attribute of their svg tag. So, in order to use these with the MudIconButton, I have to include the svg tag in the custom icon string so that I am able to configure the viewBox attribute value. This results in a funky DOM with the custom icon's svg tag nested inside of the MudIcon's wrapping svg tag.

Describe the solution you'd like

Make new Brands Icons for the following social media platforms

Have you seen this feature anywhere else?

Font Awesome has SVG icons for Twitch, Tumblr, ArtStation, and DeviantArt. https://fontawesome.com/icons/twitch https://fontawesome.com/icons/tumblr https://fontawesome.com/icons/artstation https://fontawesome.com/icons/deviantart

VeryIcon has an SVG icon for Pixiv. https://www.veryicon.com/icons/internet--web/common-social-site-icons-for-the-web/pixiv.html

Describe alternatives you've considered

Make custom icon strings that use icons from other libraries (e.g., Font Awesome).

I am doing this currently but it does not integrate with MudBlazor as nicely as the built-in Icons do.

Pull Request

Code of Conduct

ScarletKuro commented 1 year ago

Don't think this will happen, because they are not part of material icons. I can only see this as a community driven project with custom icon packs.

In order to use these with the MudIconButton, I have to include the svg tag in the custom icon string in order to configure the viewBox attribute value

Yea, I agree that this is annoying. I have to adjust my custom icons like the built ones(to fit in 0 0 24 24 viewbox) so that I wouldn't need to include the svg with viewbox to not end up with "a funky DOM with the custom icon's svg tag nested inside of the MudIcon's wrapping svg tag".

I think it would make more sense to add ViewBox property to components like MudIconButton, since inside it's using MudIcon that has this property.

ChristianHinko commented 1 year ago

Don't think this will happen, because they are not part of material icons. I can only see this as a community driven project with custom icon packs.

MudBlazor has a few custom icons as well. I think that the requested icons would fit inside of MudBlazor.Icons.Custom.Brands nicely.

I can only see this as a community driven project with custom icon packs.

I agree that this fits well in a community project. Hopefully, we will see icon packs happen in the upcoming MudStore!

henon commented 1 year ago

It is very easy to use your own svg icons. Just set the Icon parameter to the svg code of your icon. I just added an example of that to the docs: https://mudblazor.com/components/icons#custom-icons