ButtonGroup: Add `FullWidth`, Rename `VerticalAlign` to `Vertical`

MudBlazor / MudBlazor

Blazor Component Library based on Material design with an emphasis on ease of use. Mainly written in C# with Javascript kept to a bare minimum it empowers .NET developers to easily debug it if needed.

http://mudblazor.com

MIT License

7.21k stars 1.18k forks source link

ButtonGroup: Add `FullWidth`, Rename `VerticalAlign` to `Vertical` #8798

Closed danielchalmers closed 2 weeks ago

danielchalmers commented 3 weeks ago

Description

For consistency with other controls.

How Has This Been Tested?

visually

Type of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[X] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[ ] I've added relevant tests.

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.13%. Comparing base (28bc599) to head (79b0c8f). Report is 120 commits behind head on dev.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #8798 +/- ## ========================================== + Coverage 89.82% 90.13% +0.30% ========================================== Files 412 421 +9 Lines 11878 12217 +339 Branches 2364 2409 +45 ========================================== + Hits 10670 11012 +342 + Misses 681 663 -18 - Partials 527 542 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

henon commented 2 weeks ago

Added to v7.0.0 Migration Guide #8447

danielchalmers commented 2 weeks ago

please add "VerticalAlign" to the illegal parameter detector in MudComponentBase

@henon Done 👍

ScarletKuro commented 2 weeks ago

Can you fix the conflicts? Just before I hit the merge the https://github.com/MudBlazor/MudBlazor/pull/8810 was merged first.

henon commented 2 weeks ago

Ooopsi. Wasn't me :D

danielchalmers commented 2 weeks ago

@ScarletKuro ready