TimePicker: Prepare for touch support & ColorPicker: Prevent touch pan in static mode

MudBlazor / MudBlazor

Blazor Component Library based on Material design with an emphasis on ease of use. Mainly written in C# with Javascript kept to a bare minimum it empowers .NET developers to easily debug it if needed.

http://mudblazor.com

MIT License

7.21k stars 1.18k forks source link

TimePicker: Prepare for touch support & ColorPicker: Prevent touch pan in static mode #8800

Closed danielchalmers closed 2 weeks ago

danielchalmers commented 3 weeks ago

Description

Follows up on #8394 and prepares for touch support in the time picker.

Color Picker and Time Picker will no longer pan if used in static mode which was an oversight from #8394
All mouse events were changed to pointer to include touch
Refactoring was done to make the codebase more consistent and easier to work on
- I will have to make fundamental changes anyway so this will make it much easier to review
No actual functionality should have changed and that will be saved for another PR

If wanted I can do the touch work directly in this PR but it will start to get messy and may or may not get done before v7 preview.

How Has This Been Tested?

Type of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[ ] I've added relevant tests.

codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 90.62500% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 90.11%. Comparing base (28bc599) to head (23c499d). Report is 117 commits behind head on dev.

Files	Patch %	Lines
...lazor/Components/TimePicker/MudTimePicker.razor.cs	90.62%	0 Missing and 3 partials :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #8800 +/- ## ========================================== + Coverage 89.82% 90.11% +0.28% ========================================== Files 412 421 +9 Lines 11878 12211 +333 Branches 2364 2409 +45 ========================================== + Hits 10670 11004 +334 + Misses 681 664 -17 - Partials 527 543 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

henon commented 2 weeks ago

The only problem I see is that it might conflict the PR @ArieGato is working on #8567

ArieGato commented 2 weeks ago

I don't see any big issues. And I'm still strugling with the generated code not being compatible with generic constraints.

henon commented 2 weeks ago

Thanks!