Docs: Fix MudDateRangePicker editable example

MudBlazor / MudBlazor

Blazor Component Library based on Material design with an emphasis on ease of use. Mainly written in C# with Javascript kept to a bare minimum it empowers .NET developers to easily debug it if needed.

http://mudblazor.com

MIT License

7.22k stars 1.18k forks source link

Docs: Fix MudDateRangePicker editable example #8806

Closed birdalicious closed 3 weeks ago

birdalicious commented 3 weeks ago

Docs - Date range picker editable example fixed

Description

Editable parameter does not exist changed to ReadOnly

How Has This Been Tested?

visually

Type of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[x] Documentation (fix or improvement to the website or code docs)

Checklist

[x] The PR is submitted to the correct branch (dev).
[x] My code follows the code style of this project.
[x] I've added relevant tests. N/A

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.11%. Comparing base (28bc599) to head (9eca8a6). Report is 115 commits behind head on dev.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #8806 +/- ## ========================================== + Coverage 89.82% 90.11% +0.28% ========================================== Files 412 420 +8 Lines 11878 12213 +335 Branches 2364 2409 +45 ========================================== + Hits 10670 11006 +336 + Misses 681 664 -17 - Partials 527 543 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

ScarletKuro commented 3 weeks ago

Hi, Thanks for PR.

@henon is this something that should be added to https://github.com/MudBlazor/MudBlazor/pull/8771 or it's just something old / added by mistake. Also, shouldn't we renamed the Editable for MudPicker to ReadOnly? Feels wrong that we have different property names for same thing.

henon commented 3 weeks ago

Yes, ReadOnly is the new standard now. We have to roll it out where it is not yet used.