Open esda98 opened 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.14%. Comparing base (
28bc599
) to head (d2b71dd
). Report is 116 commits behind head on dev.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
IconOnly
should probably be a cascading value or be forced on all children. In what situation would some be icon-only and not other?
Should it collapse the title too? Not sure how that would work
Side note: the hamburger menu icon should really align with the rest
Titles in the new example are too far to the right and don't look right
Should it collapse the title too? Not sure how that would work
Side note: the hamburger menu icon should really align with the rest
I agree with this
@esda98 this example isn't intuitive. Nobody will figure out that they have to click the burger icon to collapse. Just add a MudSwitch at the bottom of the example that says IconOnly
instead
Compare with the Variant="DrawerVariant.Mini"
example in the drawer docs, this would be also a good way of improving the example
This PR adds a
boolean
property to the MudNavLink and MudNavGroup components that controls the conditional rendering of the child elements of MudNavLink and the Title of MudNavGroup.Description
The PR adds an
if
around the<div>
tags that wrap@ChildContent
for MudNavLink and@Title
for MudNavGroup controlled by the new boolean parameter for the components namedIconOnly
.This is to enable functionality of collapsed sidebars, common in vertical navigation pane paradigms, to save horizontal space but still allow navigation through the icons on the sidebar.
How Has This Been Tested?
Type of Changes
Examples
https://github.com/MudBlazor/MudBlazor/assets/6509976/f36cfc67-b397-4ea0-948d-d8288bdfdcf3
Checklist
dev
).