Open Saman-00 opened 3 weeks ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 90.49%. Comparing base (
28bc599
) to head (2fae789
). Report is 176 commits behind head on dev.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Strangely the notification popover still seems to get clipped (https://github.com/MudBlazor/MudBlazor/issues/7032#issuecomment-2055959684)
Shrink the window until it changes layout, click the hamburger menu, then click the notifications icon to see
Strangely the notification popover still seems to get clipped (#7032 (comment))
Shrink the window until it changes layout, click the hamburger menu, then click the notifications icon to see
Do you mean that the popover still goes outside the window after my changes? because I can't reproduce that.
But my notification area looks wrong, maybe that is the reason
That seems to be working now, not sure if i was on the wrong branch before (🤦 )
Seems to be a miscalculation with the scrolling now:
https://github.com/MudBlazor/MudBlazor/assets/7112040/dbe6341c-a205-4f07-98b7-5f82da533c2a
See notifications:
What do you think about this by the way https://github.com/MudBlazor/MudBlazor/issues/1167#issuecomment-2075508364? I want to get the tooltip layout fixed but something needs to be adjusted in the javascript (try settings display: contents
on a tooltip then hover over it).
Description
popover-content
is positioned based on the parent element of theMudPopover
component, and when this parent element is outside the browser window, the popup also goes outside the window and is partially visible or not visible at all, this seems to be a common occurrence inMudDataGrid
's simple filter popover when the grid has a scroll.This behavior can be viewed here: https://try.mudblazor.com/snippet/cOGeEScJpoYZVWLx This commit attempts to fix the issue by preventing the popover from going outside the window. It potentially fixes these issues: Fixes #8180, fixes #8173, fixes #7032, fixes #7707
This video shows how it currently is: https://github.com/MudBlazor/MudBlazor/assets/5804803/803e4884-a5b0-4452-ae4c-afe2552c3ed8 This one shows how it will behave after the change: https://github.com/MudBlazor/MudBlazor/assets/5804803/5f30914b-9bd0-4680-a603-246639298a47
How Has This Been Tested?
This change has been tested visually, I made a component out of the TryMudBlazor snippet and tested manually.
Type of Changes
Checklist
dev
).