MudBlazor / MudBlazor

Blazor Component Library based on Material design with an emphasis on ease of use. Mainly written in C# with Javascript kept to a bare minimum it empowers .NET developers to easily debug it if needed.
http://mudblazor.com
MIT License
7.21k stars 1.18k forks source link

Standardise the use of `Checked`, `CheckedChanged` and `Checkable` #8825

Closed BieleckiLtd closed 2 weeks ago

BieleckiLtd commented 2 weeks ago

MudBlazor currently uses the Checked and IsChecked properties. This PR aims to standardise the use of Checked, CheckedChanged and Checkable.

Description

If this PR is approved, the v7 migration guide must also be updated, as this makes a breaking change:

MudRatingItem: replace IsChecked with Checked MudTableGroupRow: replace IsCheckable with Checkable MudTableGroupRow: replace IsChecked with Checked MudTFootRow: replace IsCheckable with Checkable MudTFootRow: replace IsChecked with Checked MudTHeadRow: replace IsCheckable with Checkable MudTHeadRow: replace IsChecked with Checked MudTr: replace IsCheckable with Checkable MudTr: replace IsCheckedChanged with CheckedChanged MudTr: replace IsChecked with Checked

Linked issues: Negative property names should be discouraged #6131 v7.0.0 Migration Guide #8447

Standardise the use of IsEnabled and Enabled #8764 Standardise the use of ItemDisabled #8887 Standardise the use of Checked, CheckedChanged and Checkable #8825 Standardise the use of Visible #8832 Standardise the use of Selected and SelectedChanged #8886 Standardise the use of Expanded, Expandable, IsExpanded and IsExpandable #8718 Standardise the use of Active #8888 Standardise the use of Open and OpenChanged #8891 Standardise the use of Editable #8892 Standardise the use of Hidden and HiddenChanged #8952

How Has This Been Tested?

unit

Type of Changes

Checklist

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 68.75000% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 90.09%. Comparing base (28bc599) to head (4bbcb6c). Report is 122 commits behind head on dev.

Files Patch % Lines
...rc/MudBlazor/Components/Table/MudTFootRow.razor.cs 33.33% 1 Missing and 1 partial :warning:
...rc/MudBlazor/Components/Table/MudTHeadRow.razor.cs 66.66% 1 Missing :warning:
...dBlazor/Components/Table/MudTableGroupRow.razor.cs 66.66% 1 Missing :warning:
src/MudBlazor/Components/Table/MudTr.razor.cs 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #8825 +/- ## ========================================== + Coverage 89.82% 90.09% +0.26% ========================================== Files 412 421 +9 Lines 11878 12211 +333 Branches 2364 2409 +45 ========================================== + Hits 10670 11002 +332 + Misses 681 666 -15 - Partials 527 543 +16 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

henon commented 2 weeks ago

Thanks!

Added to v7.0.0 Migration Guide #8447