Closed henon closed 2 weeks ago
FYI @BieleckiLtd
Attention: Patch coverage is 85.18519%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 90.12%. Comparing base (
28bc599
) to head (66c31a4
). Report is 125 commits behind head on dev.
Files | Patch % | Lines |
---|---|---|
...lazor/Components/Dialog/MudDialogInstance.razor.cs | 33.33% | 2 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Some are ambiguous or hard to tell what it does at a glance. The problem has always been that it's easy for these properties to sound like configuration points (Alpha sounds like you can change the alpha).
Some ideas:
SliderAnimation
-> AnimateSlider
Preview
-> ShowPreview
ModeSwitch
-> AllowSwitchingModes
DragEffect
-> AllowPointerDrag
(i would remove this property entirely)ColorField
-> probably fine but also: ShowColorField
(ShowColorSpectrum
??)Alpha
-> EnableAlpha
??I like AnimateSlider
and ShowPreview
.
As for Toolbar, the component is called MudPickerToolbar
. I guess we really should rename MudToolBar
.
I decided to keep SliderAnimation
. It is consistent with other things like Ripple
. DragEffect
is also consistent with that.
In ColorPicker I added Show almost everywhere, it feels better that way and is more consistent also: ShowPreview
, ShowColorField
, ShowAlpha
, ShowModeSwitch
.
Ready for merge.
Added to v7.0.0 Migration Guide #8447
Description
Resolves #6131
DisableLegend
withShowLegend
and invert valueDisableToolbar
withShowToolbar
and invert valueDisableToolbar
withShowToolbar
and invert valueToolBarClass
withToolbarClass
DisableSidePadding
withGutters
and invert valueDisableOverlay
withOverlay
and invert valueDisableSliderAnimation
withSliderAnimation
and invert valueDisableModifiers
withModifiers
and invert valueMudColorPicker
DisableSliders
withShowSliders
and invert valueDisablePreview
withShowPreview
and invert valueDisableModeSwitch
withShowModeSwitch
and invert valueDisableInputs
withShowInputs
and invert valueDisableDragEffect
withDragEffect
and invert valueDisableColorField
withShowColorField
and invert valueDisableAlpha
withShowAlpha
and invert valueType of Changes
Checklist
dev
).