MudBlazor / MudBlazor

Blazor Component Library based on Material design with an emphasis on ease of use. Mainly written in C# with Javascript kept to a bare minimum it empowers .NET developers to easily debug it if needed.
http://mudblazor.com
MIT License
7.21k stars 1.18k forks source link

Rename remaining Disable... properties #8826

Closed henon closed 2 weeks ago

henon commented 2 weeks ago

Description

Resolves #6131

MudColorPicker

Type of Changes

Checklist

henon commented 2 weeks ago

FYI @BieleckiLtd

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 85.18519% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 90.12%. Comparing base (28bc599) to head (66c31a4). Report is 125 commits behind head on dev.

Files Patch % Lines
...lazor/Components/Dialog/MudDialogInstance.razor.cs 33.33% 2 Missing and 2 partials :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #8826 +/- ## ========================================== + Coverage 89.82% 90.12% +0.29% ========================================== Files 412 421 +9 Lines 11878 12216 +338 Branches 2364 2410 +46 ========================================== + Hits 10670 11010 +340 + Misses 681 664 -17 - Partials 527 542 +15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielchalmers commented 2 weeks ago

Some are ambiguous or hard to tell what it does at a glance. The problem has always been that it's easy for these properties to sound like configuration points (Alpha sounds like you can change the alpha).

Some ideas:

henon commented 2 weeks ago

I like AnimateSlider and ShowPreview.
As for Toolbar, the component is called MudPickerToolbar. I guess we really should rename MudToolBar.

henon commented 2 weeks ago

I decided to keep SliderAnimation. It is consistent with other things like Ripple. DragEffect is also consistent with that.

In ColorPicker I added Show almost everywhere, it feels better that way and is more consistent also: ShowPreview, ShowColorField, ShowAlpha, ShowModeSwitch.

henon commented 2 weeks ago

Ready for merge.

henon commented 2 weeks ago

Added to v7.0.0 Migration Guide #8447