Replace `mud-*-full` with `mud-full-*`

MudBlazor / MudBlazor

Blazor Component Library based on Material design with an emphasis on ease of use. Mainly written in C# with Javascript kept to a bare minimum it empowers .NET developers to easily debug it if needed.

http://mudblazor.com

MIT License

7.21k stars 1.18k forks source link

Replace `mud--full` with `mud-full-` #8828

Closed danielchalmers closed 2 weeks ago

danielchalmers commented 2 weeks ago

Description

Replaces usage of obsolete CSS properties in our code while keeping them for legacy users.

How Has This Been Tested?

⚠️ completely untested

Type of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[ ] I've added relevant tests.

codecov[bot] commented 2 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.14%. Comparing base (28bc599) to head (db96493). Report is 120 commits behind head on dev.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #8828 +/- ## ========================================== + Coverage 89.82% 90.14% +0.31% ========================================== Files 412 421 +9 Lines 11878 12216 +338 Branches 2364 2409 +45 ========================================== + Hits 10670 11012 +342 + Misses 681 663 -18 - Partials 527 541 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

henon commented 2 weeks ago

I searched the changes for scss but didn't find anything. Did you not add the new classes mud-full-width and mud-full-height ? AFAIK they don't exist yet.