Closed BieleckiLtd closed 1 week ago
Attention: Patch coverage is 85.71429%
with 4 lines
in your changes are missing coverage. Please review.
Project coverage is 90.13%. Comparing base (
28bc599
) to head (d91a0c0
). Report is 142 commits behind head on dev.
Files | Patch % | Lines |
---|---|---|
...lazor/Components/MessageBox/MudMessageBox.razor.cs | 20.00% | 4 Missing :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
@BieleckiLtd I wanted to merge this but I noticed that we probably should always also add the eventcallback to the illegal param detector for the cases where people didn't use the @bind-
syntax. I.e. IsVisibleChanged
. You could also add the event callbacks for your other standardization PRs, i.e. IsCheckedChanged
etc.
@BieleckiLtd I wanted to merge this but I noticed that we probably should always also add the eventcallback to the illegal param detector for the cases where people didn't use the
@bind-
syntax. I.e.IsVisibleChanged
. You could also add the event callbacks for your other standardization PRs, i.e.IsCheckedChanged
etc.
I did add IsCheckedChanged
but you might be right about IsVisibleChanged
. I will double check.
Added IsVisibleChanged
to DetectIllegalRazorParametersV7
and updated migration guide:
MudDialog: replace IsVisibleChanged
with VisibleChanged
MudMessageBox: replace IsVisibleChanged
with VisibleChanged
MudTooltip: replace IsVisibleChanged
with VisibleChanged
Thanks @BieleckiLtd . Do you think we need to standardize other things as well or should we call it a day for v7?
Oh, I see you were planning on doing IsDisabled, IsSelected, IsActive and IsValid as well.
@BieleckiLtd I think we may want to leave IsValid
as is in IForm
and MudForm
as EditForm
and FluentValidation
both use IsValid
and if we change MudForm
to Valid
it would actually increase inconsistency instead of decreasing it.
I'd like to do IsSelected and IsActive over the weekend. I believe IsDisabled was changed to Enabled, but I'll double check.
Great, I am changing IsTouched
to Touched
as we also have Touched
already.
Edit: I decided to leave IsTouched alone also. We might want to change it again after reworking form in v8 so it doesn't make much sense to touch it now.
MudBlazor currently uses the
Visible
andIsVisible
properties. This PR aims to standardise the use ofVisible
.Description
If this PR is approved, the v7 migration guide must also be updated, as this makes a breaking change:
MudCarouselItem: replace
IsVisible
withVisible
ChartSeries: replaceIsVisible
withVisible
SvgLegend: replaceIsVisible
withVisible
MudDialog: replaceIsVisible
withVisible
MudDialog: replaceIsVisibleChanged
withVisibleChanged
MudMessageBox: replaceIsVisible
withVisible
MudMessageBox: replaceIsVisibleChanged
withVisibleChanged
MudTooltip: replaceIsVisible
withVisible
MudTooltip: replaceIsVisibleChanged
withVisibleChanged
Linked issues: Negative property names should be discouraged #6131 v7.0.0 Migration Guide #8447
Standardise the use of
IsEnabled
andEnabled
#8764 Standardise the use ofItemDisabled
#8887 Standardise the use ofChecked
,CheckedChanged
andCheckable
#8825 Standardise the use ofVisible
#8832 Standardise the use ofSelected
andSelectedChanged
#8886 Standardise the use ofExpanded
,Expandable
,IsExpanded
andIsExpandable
#8718 Standardise the use ofActive
#8888 Standardise the use ofOpen
andOpenChanged
#8891 Standardise the use ofEditable
#8892 Standardise the use ofHidden
andHiddenChanged
#8952How Has This Been Tested?
unit
Type of Changes
Checklist
dev
).