Update _table.scss to Use Inherited Font Size

MudBlazor / MudBlazor

Blazor Component Library based on Material design with an emphasis on ease of use. Mainly written in C# with Javascript kept to a bare minimum it empowers .NET developers to easily debug it if needed.

http://mudblazor.com

MIT License

7.39k stars 1.19k forks source link

Update _table.scss to Use Inherited Font Size #8984

Open neozhu opened 3 weeks ago

neozhu commented 3 weeks ago

Description:

This PR modifies the _table.scss file by changing the font-size property from 0.875 to inherit.

Changes:

Updated _table.scss:
- font-size: 0.875 -> font-size: inherit

Benefits:

This change allows the font size in tables and datagrids to be synchronized with the default font size defined in the Theme. This ensures consistency in typography across the application and makes it easier to manage font sizes through the Theme settings.

Testing:

Verified that tables and datagrids now use the inherited font size from the Theme.
Checked for any visual regressions to ensure the change does not negatively impact the UI.

danielchalmers commented 3 weeks ago

does the line-height and letter-spacing need to be inherited too?

codecov[bot] commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 90.57%. Comparing base (28bc599) to head (b1de178). Report is 222 commits behind head on dev.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #8984 +/- ## ========================================== + Coverage 89.82% 90.57% +0.74% ========================================== Files 412 397 -15 Lines 11878 12313 +435 Branches 2364 2396 +32 ========================================== + Hits 10670 11153 +483 + Misses 681 621 -60 - Partials 527 539 +12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

danielchalmers commented 3 weeks ago

Like this in a few components:

Need to check with @Garderoben if it's intentional