Upgrade to MudBlazor 7.0.0-rc.2 and Latest Blazor Project Templates

jperson2000 commented 6 months ago

Description

Fixes: https://github.com/MudBlazor/Templates/issues/451 Fixes: https://github.com/MudBlazor/Templates/issues/466 Fixes: https://github.com/MudBlazor/Templates/issues/467 Fixes: https://github.com/MudBlazor/Templates/issues/458 Fixes: https://github.com/MudBlazor/Templates/issues/450 Fixes: https://github.com/MudBlazor/Templates/issues/455 Replaces PR: https://github.com/MudBlazor/Templates/pull/452 Replaces PR: https://github.com/MudBlazor/Templates/pull/459

This update upgrades the MudBlazor templates to use the latest Blazor .NET 8 templates and MudBlazor 7 RC 2. This update also uses the MudBlazor.Static library by @Anu6is to upgrade Account pages (which use Static rendering).

Interactive Auto (Dark Mode)

Interactive Auto (Light Mode)

Register

Login

Profile

Change Email

Change Password

Two-factor authentication

Personal Data

How Has This Been Tested?

This was tested by:

Running .\InstallAndBuildAllTemplates.ps1 PowerShell script
Observing that all builds succeeded
Opening each solution and testing all links

Type of Changes

[ ] Bug fix (non-breaking change which fixes an issue)
[ ] New feature (non-breaking change which adds functionality)
[X] Breaking change (fix or feature that would cause existing functionality to not work as expected)
[ ] Documentation (fix or improvement to the website or code docs)

Checklist

[X] The PR is submitted to the correct branch (dev).
[X] My code follows the code style of this project.
[ ] I've added relevant tests.

jperson2000 commented 6 months ago

@ScarletKuro @henon @danielchalmers @mikes-gh Here's a PR for the .NET 8 MudBlazor 7.0.0-preview.4 templates. (I had to start over.) Currently, the template has the basic pages updated and the test PS script works, but I had some questions about what else you'd like to see:

Do you want all of the auth pages (about 20 of them) upgraded to MudBlazor components?
The template has something which may feel like a bug to end users. The Microsoft Identity code has options.SignIn.RequireConfirmedAccount = true in it, which means nobody who registers an account can immediately log in until they connect to the database and manually modify their record. I would like to change this flag to false to fix this (and it works), but it's less secure. Are you okay with this change?
The Home.razor page in the template has one set of instructions for all project types. Shall we make this more dynamic to show different messages per project type? (I would vote yes)

ScarletKuro commented 5 months ago

Global Mode without Auth:	Mode	Status
Auto	Working
Wasm	Working
Server	Working

Per page without Auth:	Mode	Status
Auto	Working	-
Wasm	Working	-
Server	Working	-

I didn't check the static SSR yet (auth). I think we need to fix the per page first to move on the next step.

ScarletKuro commented 5 months ago

Can we control the default selection mode? I would want it to be global -> wasm. That would eliminate a lot of complaints/issues, as many newbie people just hit the next button.

jperson2000 commented 5 months ago

Can we control the default selection mode? I would want it to be global -> wasm. That would eliminate a lot of complaints/issues, as many newbie people just hit the next button.

Yes, I was able to change the defaults in template.json, in the InteractivityPlatform and InteractivityLocation sections.

jperson2000 commented 5 months ago

Per page without Auth: Auto/Wasm Not Working

Thanks @ScarletKuro , I have fixed these issues and have retested all templates. Also:

The Dark/Light Mode button only appears for apps without Auth
The default template is now WebAssembly/Global
The bootstrap.css and app.css are now only included by App.razor while viewing Auth pages.

... the only issue I couldn't figure out is regarding app.css and Auth pages. The CSS shows underlines for links in the Nav Panel, but the non-Auth pages look okay:

sonarcloud[bot] commented 5 months ago

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

ScarletKuro commented 5 months ago

Thanks @ScarletKuro , I have fixed these issues and have retested all templates

Great work.

... the only issue I couldn't figure out is regarding app.css and Auth pages. The CSS shows underlines for links in the Nav Panel, but the non-Auth pages look okay:

My offer would be both drop the app.css and bootstrap.css and use: https://github.com/0phois/MudBlazor.StaticInput https://www.nuget.org/packages/Extensions.MudBlazor.StaticInput by @Anu6is for the login/register pages, there is sample on the repo.

ScarletKuro commented 5 months ago

Ah, I just noticed it's for v6 :( I don't think it's compatible with v7, there is v7 branch but no nuget

Anu6is commented 5 months ago

Pushed a pre-release for v7. Think I thought v7 was getting released early June so I intended to wait.

jperson2000 commented 5 months ago

Pushed a pre-release for v7. Think I thought v7 was getting released early June so I intended to wait.

Ok, thanks @Anu6is! I'm excited to check out your library and will work on the Auth pages tonight.

jperson2000 commented 5 months ago

@Anu6is your library worked beautifully for upgrading the Account pages. Thanks so much for your work on the static form components!

ScarletKuro commented 5 months ago

Everything seems to work. It's a very great work.

ScarletKuro commented 5 months ago

Is anyone willing to double check the templates itself? @henon @mikes-gh @xC0dex @Anu6is @danielchalmers Otherwise I want to merge this ASAP.

xC0dex commented 5 months ago

Is anyone willing to double check the templates itself? @henon @mikes-gh @xC0dex @Anu6is @danielchalmers Otherwise I want to merge this ASAP.

I could try it out this evening, so in about 2–3 hours 👍

henon commented 5 months ago

Thank you very much

jperson2000 commented 5 months ago

Just a quick note: When MudBlazor 7.0.0 is released, a small PR will be needed to change the Package Reference version to 7.* for templates.

ScarletKuro commented 5 months ago

Just a quick note: When MudBlazor 7.0.0 is released, a small PR will be needed to change the Package Reference version to 7.* for templates.

Yes, and MudBlazor.Static probably too.

MudBlazor / Templates