Defect in Assert methods in BaseTestWithSampleRunner

[GoogleCodeExporter]

What steps will reproduce the problem?
1. There are 2 methods (AssertLogContains and AssertLogDoesNotContain) in 
BaseTestWithSampleRunner that throw a NullReferenceException when the name of 
an empty logStream is passed as an argument.

What is the expected output? What do you see instead?

The NRE is misleading and contrary to the purpose of the methods. They should 
take the empty stream into account and still act like an Assert method. I have 
attached a patch that fixes the bug in both methods.

Please use labels and text to provide additional information.

See the attached patch file.

Original issue reported on code.google.com by justin.w...@gmail.com on 30 Aug 2010 at 4:51

Attachments:

• Fix.BaseTestWithSampleRunner.AssertMethods.20100829.patch

[GoogleCodeExporter]

Original comment by Yann.Tre...@gmail.com on 30 Aug 2010 at 10:15

• Changed state: Started
• Added labels: Component-Gallio, Milestone-3.2, Priority-Low, Type-Patch

[GoogleCodeExporter]

Applied.

Original comment by Yann.Tre...@gmail.com on 30 Aug 2010 at 10:18

• Changed state: Fixed