Mudlet / Mudlet

⚔️ A cross-platform, open source, and super fast MUD client with scripting in Lua
https://mudlet.org
GNU General Public License v2.0
738 stars 268 forks source link

Review code assignment to different TConsole::mType values #2169

Closed SlySven closed 2 weeks ago

SlySven commented 5 years ago

Brief summary of issue / Description of requested feature:

In #2138 I added code that gave a single classification to the six different types of TConsole instances. At the end of that there should not have been any functional changes but it showed up places where the choice of whether to run a particular block of code for each type of TConsole looked to be suspect. This Issue is a tracker for the places I found and which are in a check list below.

Error output / Expected result of feature

A decision is to be made at each of the positions listed to see if the set of types for the block of code needs to be adjusted considering where and what the TConsole instances concern are used for.

Extra information, such as Mudlet version, operating system and ideas for how to solve / implement:

In src/TConsole.cpp:

In src/TTextEdit.cpp:

ZookaOnGit commented 2 weeks ago

assigned but no traction, no priority, reopen if necessary