Brief summary of issue / Description of requested feature:
In #2138 I added code that gave a single classification to the six different types of TConsole instances. At the end of that there should not have been any functional changes but it showed up places where the choice of whether to run a particular block of code for each type of TConsole looked to be suspect. This Issue is a tracker for the places I found and which are in a check list below.
Error output / Expected result of feature
A decision is to be made at each of the positions listed to see if the set of types for the block of code needs to be adjusted considering where and what the TConsole instances concern are used for.
Extra information, such as Mudlet version, operating system and ideas for how to solve / implement:
Brief summary of issue / Description of requested feature:
In #2138 I added code that gave a single classification to the six different types of
TConsole
instances. At the end of that there should not have been any functional changes but it showed up places where the choice of whether to run a particular block of code for each type ofTConsole
looked to be suspect. This Issue is a tracker for the places I found and which are in a check list below.Error output / Expected result of feature
A decision is to be made at each of the positions listed to see if the set of types for the block of code needs to be adjusted considering where and what the TConsole instances concern are used for.
Extra information, such as Mudlet version, operating system and ideas for how to solve / implement:
In
src/TConsole.cpp
:TConsole::TConsole(Host*, ConsoleType, QWidget*)
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242004738TConsole::TConsole(Host*, ConsoleType, QWidget*)
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242004913TConsole::TConsole(Host*, ConsoleType, QWidget*)
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242004988void TConsole::resizeEvent(QResizeEvent*)
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242005100void TConsole::resizeEvent(QResizeEvent*)
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242005168void TConsole::resizeEvent(QResizeEvent*)
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242005260void TConsole::resizeEvent(QResizeEvent*)
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242005348void TConsole::refresh()
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242005412void TConsole::toggleLogging(bool)
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242005458void TConsole::slot_toggleLogging()
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242005486void TConsole::slot_toggleReplayRecording()
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242005555void TConsole::showEvent(QShowEvent*)
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242005640void TConsole::hideEvent(QHideEvent*)
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242005659In
src/TTextEdit.cpp
:void TTextEdit::mousePressEvent(QMouseEvent*)
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242005737void TTextEdit::mouseReleaseEvent(QMouseEvent*)
} : https://github.com/Mudlet/Mudlet/pull/2138/files#r242005757