Mudlet / mudlet-package-repo

Web server for serving Mudlet packages. Client @ https://github.com/Mudlet/MudletPackageManager
7 stars 5 forks source link

need to install luarocks inspect #99

Closed Edru2 closed 4 years ago

Edru2 commented 4 years ago

Brief overview of PR changes/additions

If I didn't install luarocks inspect and did lapis migrate I got:

lapis migrate
Error: ./config.lua:2: module 'inspect' not found:No LuaRocks module found for inspect
    no field package.preload['inspect']
    no file '/root/.luarocks/share/lua/5.1/inspect.lua'
    no file '/root/.luarocks/share/lua/5.1/inspect/init.lua'
    no file '/usr/local/share/lua/5.1/inspect.lua'
    no file '/usr/local/share/lua/5.1/inspect/init.lua'
    no file './inspect.lua'
    no file '/usr/local/lib/lua/5.1/inspect.lua'
    no file '/usr/local/lib/lua/5.1/inspect/init.lua'
    no file '/usr/share/lua/5.1/inspect.lua'
    no file '/usr/share/lua/5.1/inspect/init.lua'
    no file '/home/manuel/.luarocks/share/lua/5.1/inspect.lua'
    no file '/home/manuel/.luarocks/share/lua/5.1/inspect/init.lua'
    no file '/root/.luarocks/lib/lua/5.1/inspect.so'
    no file '/usr/local/lib/lua/5.1/inspect.so'
    no file './inspect.so'
    no file '/usr/lib/x86_64-linux-gnu/lua/5.1/inspect.so'
    no file '/usr/lib/lua/5.1/inspect.so'
    no file '/usr/local/lib/lua/5.1/loadall.so'
    no file '/home/manuel/.luarocks/lib/lua/5.1/inspect.so'
 * Run with --trace to see traceback
 * Report issues to https://github.com/leafo/lapis/issues

Motivation for adding to package repo

it won't work without it.

But another question is. Is it even needed? After checking config.lua it doesn't seem to be used by anything.

vadi2 commented 4 years ago

It helps with debugging, it's basically display()

Edru2 commented 4 years ago

Can you add it to the Dockerfile as well?

I didn't test if it works but it seems to be already present in the dockerfile. https://github.com/Mudlet/mudlet-package-repo/blob/b5ffc2d68c97eb969324da01c1663b8cfd53562c/Dockerfile#L19