Muetze42 / nova-menu

Heroicon, Font Awesome, SVG & Image Icon for Nova MenuSection, MenuGroup & MenuItem. And new features like Cards, Iframe, Filter.
https://novapackages.com/packages/norman-huth/nova-menu
19 stars 4 forks source link

Highlighting lost after last update #19

Closed dm-pf closed 1 year ago

dm-pf commented 1 year ago

Hi, thanks for this wonderful package!

You probably did a "Find & Replace" which is a handy but scary functionality in your IDE.

https://github.com/Muetze42/nova-menu/blob/7359d48c30051e59e6ab59b9321f4fc01aea79a9/resources/js/components/MenuItem.vue#L7

That isn't how class binding works. You might want to do something like this instead?

:class="{ 'inertia-link-active': item.active, item.icons.classes.elem: true }" 
Muetze42 commented 1 year ago

https://github.com/Muetze42/nova-menu/releases/tag/1.3.3