search

Muetze42 / nova-menu

Heroicon, Font Awesome, SVG & Image Icon for Nova MenuSection, MenuGroup & MenuItem. And new features like Cards, Iframe, Filter.
https://novapackages.com/packages/norman-huth/nova-menu
19 stars 4 forks source link

When Menu Section is closed, after using menu search, section is not opened #51

Open webard opened 8 months ago

webard commented 8 months ago

Hello,

When I search in menu and founded item is in closed section, this section won't open:

image
Muetze42 commented 8 months ago

I can't reproduce it.

Should closed menus open when they are closed?

webard commented 8 months ago

Should closed menus open when they are closed?

I think yes, closed menu, if search condition is met for it's resources, should be opened.

Muetze42 commented 8 months ago

Hmm. I'd have to think about that.

The filter is in the MainMenu component and MenuGroup and MenuSection are collapsible.
https://github.com/Muetze42/nova-menu/tree/main/resources/js/components

Whether a menu is open or closed is determined by values in the local storage and not by CSS...

webard commented 8 months ago

Thank you. I think this feature should enhance overall user experience with menu.