search

MuffinManKen / AutoBar

10 stars 10 forks source link

[Classic ERA] AutoBar:RegisterDB("AutoBarDB", nil, "class") causing lua error on 1.14.4 #50

Closed Lefaux closed 1 year ago

Lefaux commented 1 year ago

With the last update from 23.08.2023 it seems a pretty big API change has been introduced. AutoBar fails with AutoBarClassic/AutoBarDB.lua:128: attempt to index field 'account' (a nil value) [string "@AutoBarClassic/AutoBarDB.lua"]:128: in functionInitializeDB' [string "@AutoBarClassic/Core.lua"]:241: in function InitializeZero' [string "@AutoBarClassic/Core.lua"]:418: in function?' [string "@AutoBarClassic/Core.lua"]:141: in function <AutoBarClassic/Core.lua:136>`

My knowledge of lua is not big enough to trace it down into the details of WoW but it feels like something that was public before no longer is public.

If you find the time to look into this I'd really appreciate it, since AutoBar has been a trusty companion of mine for a LONG time :)

Lefaux commented 1 year ago

@MuffinManKen Is there a way to hire you in some fashion? I understand you no longer play the game, but I could provide you with everything you'd need.

Hit me up if you're interested :)

Lefaux commented 1 year ago

Interesting fact: I cloned this repo and manually put together the release for Classic ERA here https://github.com/Lefaux/AutoBarClassic From what I see so far, it seems to work.

Maybe it just takes a release?

jasskin commented 1 year ago

I am not seeing a published release on your Fork I downloaded the zip from the code page but still not working for me. Neither your fork or Muffins are showing up on PTR even under the addon list but it does load and through errors in game. I also don't see that the curseforge updater is picking up that I have it installed on the PTR.

jasskin commented 1 year ago

Re-installed the Addon from Curse it now at least is showing up.

Lefaux commented 1 year ago

I didn't test PTR to be honest. On classic ERA EU it works for me - maybe the version in the TOC is wrong for the PTR?

MuffinManKen commented 1 year ago

So was the issue basically that the Classic API caught up with the Retail API?

Lefaux commented 1 year ago

@MuffinManKen It seems that blizzard has unified the clients and parts of the API (which makes a lot of sense if you ask me) I'm not too deep into WoWs API, but what I saw isa that GetBagName() is no longer globally available but needs to be called via C_Container.GetBagName()

MuffinManKen commented 1 year ago

I'll get out a fix for this soon. I've also launched a Kickstarter to do further development: https://www.kickstarter.com/projects/2075655491/autobar-2023